Match the Microsoft.Extensions.Logging LogLevels CRITICAL and TRACE to the corresponding log4net.Core Levels about microsoft.extensions.logging.log4net.aspnetcore HOT 7 CLOSED

Hello @moberacker ,

No problem to add the Trace() extension method.

But with the Critical / Fatal one, I have concerns, because right now the Critical LogLevel already is registering a Fatal message. I will take a deep look and I'll be back to you.

Thank you by your help. Regards.

from microsoft.extensions.logging.log4net.aspnetcore.

Hello again @moberacker ,

Do you have any justification to propose to change from Fatal to Critical?

For me are both the same, considering this SO answer: https://stackoverflow.com/a/5278006/982431

Let me know your thougts on this.

from microsoft.extensions.logging.log4net.aspnetcore.

Hello @huorswords ,

because I think it's more usefull to map Microsoft.Extensions.Logging.LogLevel Critical to the depending level of the underlying Logging Framework if it is available. Maybe you could add an appsettings property to support this mapping by configuration?

Regards,
Markus

from microsoft.extensions.logging.log4net.aspnetcore.

Hello @moberacker ,

I am working for some time on this issue, and I have implemented a way to be able to use Critical instead Fatal following your suggestion and using your extension methods. Thank you very much.

To be able to setup the log level for critical messages within Critical level instead of the fatal one (by default), you should initialize AddLog4Net using a Log4NetProviderOptions class.

The OverrideCriticalLevelWith property of this class allows you to indicate "Critical" to let the logger know that should use Critical level instead of the Fatal level when a Critical message is sent to be written by the logger. Any other value, is not considered and use Fatal as default.

You can configure the Log4NetProviderOptions class by two ways:

• Manually on your code.
• When you initialize the log4net logging module, import the appsettings.json section, adding something like the following into your appsettings.json

"Log4NetCore": {
	"OverrideCriticalLevelWith": "Critical",
}

Is it a valid approach for you?

Thank you.

from microsoft.extensions.logging.log4net.aspnetcore.

Hello @huorswords ,

yes it's ok but don't forget to also include OverrrideTraceLevelWith : "Trace" to Log4NetCore.

Regrards,
Markus

from microsoft.extensions.logging.log4net.aspnetcore.

Hello,

Not needed. The Trace level itself will be registered as is instead the actual behavior, that is via Debug level.

I will merge the changes as soon as possible and the new release will be available in the same day.

Thank you very much.

from microsoft.extensions.logging.log4net.aspnetcore.

Available on v.2.2.5

Please refer to documentation for more details.

from microsoft.extensions.logging.log4net.aspnetcore.