Support for configuration watching about microsoft.extensions.logging.log4net.aspnetcore HOT 4 CLOSED

Hello @DvirL ,

Thank you very much by your request.

Could it be acceptable to you to provide an override of the constructor that accepts a boolean argument that indicates whether it should watch or not?

Of course, this change will include the corresponding override of the extension method to indicate this argument also. By default, the behavior will be not to watch for changes.

Let me know your thoughts on this.

Thank you again.

from microsoft.extensions.logging.log4net.aspnetcore.

This would be very useful for some projects I have got.
However, I wonder if it would be possible to enable the use of built in IOptions and IOptionsMonitor (if that is still a thing). this would enable adding the config to the usual IConfigurationRoot and enable reload ability. The only problem I see is that Log4Net requires and XmlDocument. But this could be worked around by "Serializing" the options back into xml to pass to Log4Net.

Opinions welcome as I was debating on looking at trying to implement this myself in a fork.

from microsoft.extensions.logging.log4net.aspnetcore.

I tried to implement this on my fork too. Furthermore, I have written code to support change of parameters in the code during startup. It is shown in PR #26

from microsoft.extensions.logging.log4net.aspnetcore.

Hello @DvirL,

I have included watching options on develop branch, as now you can do next:

factory.AddLog4Net("log4net.config", true)

This code snippet should allow you to configure the extensions to watch for changes on log4net.config file.

Waiting for the @chanjunweimy PR to be reviewed, this will be merged into master as soon as possible.

Regards

from microsoft.extensions.logging.log4net.aspnetcore.