Comments (5)
In my opinion cName
makes it only worse as encourages reader to use confusing parameter names. classArg
would be ok. I don't see much benefit anyway.
from youmightnotneedjquery.
The benefit would be to prevent readers from thinking that the className
to the left of the +=
operator represents the same entity as the className
to the right of +=
. Different entities shouldn't be given the same name. The way this code example is written won't run.
The choice of cName
comes from Mozilla Developer Network. I'm impartial to it specifically.
from youmightnotneedjquery.
@janaspage I understand the benefit. Actually, I'm using the code as such and it runs for me. I still think that cName
is not an ideal name.
from youmightnotneedjquery.
Sorry, I should be more specific. The code as written works only if the user replaces the last appearance of className
with the string 'className'
, or if the user previously defines className
to be a variable whose value is a string naming the desired class.
My suggestion is not to represent user variables with names that are identical to native property names or reserved keywords, as it potentially complicates debugging. Thanks for your consideration. Cheers.
from youmightnotneedjquery.
Going to keep them as-is for now
from youmightnotneedjquery.
Related Issues (20)
- Modernization HOT 17
- Replace slider with radio buttons or select HOT 9
- Bugs with Brazilian/Portuguese internationalization HOT 1
- Don't change URL query params by default HOT 1
- Support adding HTML for a defer/module load example
- I18n HOT 3
- Support for refresh an element HOT 3
- Namespaced Events
- Event delegation does not match jQuery behaviour HOT 3
- The selector option of Prev does not match jQuery behaviour
- Spread operator is not needed for the iterable in for...of
- Last is having a NodeList uses array method directly
- Trigger Native needs to be looked into HOT 2
- Next is missing the feature of optional selector, which the jQuery version has HOT 1
- The `:visible` selector is not listed HOT 1
- Example with error HOT 1
- Some example, why not jquery for readibility ? HOT 4
- Unnecessary return of undefined in modern next and prev HOT 2
- Example for `scrollTop` not working HOT 1
- Specify append is only for text HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from youmightnotneedjquery.