Comments (11)
Same here: it works in Firefox, but in Chrome you have to touch to sort table.
from sortable.
Ahh, it makes sense that would be the behavior based on this and this.
If we bind to both touchstart
and click
, maybe we could do something like this? @zackbloom know of a better pattern here?
from sortable.
What you really want is Pointer Events (https://github.com/jquery/PEP), but as browser support is not great yet, a common thing is to bind to both touchstart
and click
, but either debounce (like the first example in that SO post), or mark the event as handled somehow (like the second). I think what you suggest would do exactly what you need.
from sortable.
whoa cool, thanks. microsoft is killin it right now :P
cool, yeah. is that kosher though marking the event itself?
from sortable.
Depends who you ask. I would double check that it doesn't error in old-IE or Safari, but my guess is that you'll get away with it.
from sortable.
hehe k, thx
from sortable.
Fixed with cab1613
from sortable.
Hmm... Yust tested your demo http://github.hubspot.com/sortable/ in the latest Firefox on classic old-school desktop (without touch support) on Windows 10. Here is the screencast: https://www.youtube.com/watch?v=E33lwZd8dio
from sortable.
@smartcorestudio thanks so much for sharing that. v0.8.0 should fix it. Please let me know if it doesn’t. Thanks!
from sortable.
It works OK now! Thank you for quick fix!
from sortable.
@smartcorestudio awesome. No problem! Thanks for the video. 👍
from sortable.
Related Issues (20)
- Publish sortable on npm HOT 2
- Only sorts the first tbody
- Sort handler triggered twice on mobile HOT 1
- first sorting column -- bug or feature? HOT 4
- no support for multiple header rows HOT 2
- trouble with manual install directions? HOT 1
- Sorting stops working once table is changed HOT 10
- make first column static HOT 2
- Mobile support HOT 5
- Money? HOT 1
- Locale Date field not sorting
- IE8 Compatibility
- Radio Input losing Checked status
- Sort fails for table inside table cell
- touch devices fires sorting twice HOT 3
- Documentation
- Pagination and performance for larger datasets HOT 1
- 为什么使用ng-repeat出来的不能排序
- Sorting does not work with colspans in header
- Merge PRs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sortable.