Comments (3)
@rubenhorn There is already a way to get the MPI rank anywhere, without passing it everywhere or calling MPI_comm_rank excessively: coupling::indexing::IndexingService<dim>::getInstance().getRank()
.
Note that it will always return the rank relative to the PinT domain (i.e. temporal subdomain if the simulation is time parallel), not the rank in MPI_COMM_WORLD, but I guess that is actually desired here. (For writing output to the logging system from time parallel simulations, the 'time local' rank AND the PinT domain number should be printed, not the global rank)
from mamico.
In general there is a lot of std::cout << ...
(1258 occurrences to be exact).
Perhaps we should (gradually) replace them with a logger that takes either verbosity level or tag as a parameter, a runtime parameter to filter before output and a default option in CMake.
from mamico.
The logging function should also automatically include configurable additional information:
- The Unix timestamp of the output
- The MPI rank (How… call
MPI_comm_rank
every time? Seems excessive) - The
__FILE__
and__LINE__
of the log statement (Requires use of a macro, but I think it may be permissible if it is only used as a simple wrapper for the logging function)
from mamico.
Related Issues (20)
- Rename CouetteSolverInterface
- Config validation HOT 2
- Code file referenced in configuration templates
- Class diagrams in Doxygen
- MultiMDServiceTest::testAvgNumberOfMDSimulations does not run sequentially HOT 2
- Upload coverage data as artifact? HOT 1
- Refactor IndexingService::getUniqueRankForMacroscopicCell
- postMultiInstanceFilterPipeline not included in filtering runtime HOT 1
- IndexingServiceTest does not compile and a test fails in sequential HOT 1
- MultiMDCellService modifies MolecularDynamicsConfiguration HOT 1
- Refactoring during MaMiCo Coding Week February 2024 HOT 1
- Use valid XML for config files
- Move the defintion of the OpenFoam-installation-directory from couette.xml to a CMAKE-Flag
- Enhance Wiki/Documentation
- Collective MPI
- NaNs after ca. 220 coupling cycles HOT 1
- CI test ls1 files
- Excessive output by NLM filter
- SimpleMD fails during equ. with 120³ domain
- /examples 👉 /tools
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mamico.