Comments (5)
Some clarification; reimplementing was my idea, since this branch is before the clang-tidy reformat of the whole codebase. Hence, automatic merging (which I tried) does not merge properly, I faced the same issues as back then. For example, git does not detect the large function signatures as the same, and often puts two of the same function in the same file. So I thought it's probably just easier to grab the needed code from the branch and update it in a new branch.
Unless anyone else has other ideas?
from mamico.
Starting work on new branch.
Track difference between the original and reimplementation here (only considers changes on one branch)
and that between the master and the reimplementation here.
from mamico.
Manual test of correctness using 4 MD instances:
MPI-collective:
with 6a406ca3e2c1958eb875409d9d94c981 couette.xml.template
Sequential:
with 6a406ca3e2c1958eb875409d9d94c981 couette.xml.template
Comparison:
md5sum *.csv *.vtk | awk '{print $1}' > output.hashes # Ignore different filenames
diff output.hashes /path/to/sequential/version/output.hashes # Finds no difference
from mamico.
Manual test of correctness using dynamic MD ensemble:
MPI-collective:
with 3254eb45201b39cf95bcf0aaba6a27c6 based on couette.xml.template
with fix-seed="yes"
and
number-md-simulations="dynamic"
min-number-md="4"
error-start="0.1"
error-end="0.05"
Sequential:
with 3254eb45201b39cf95bcf0aaba6a27c6 based on couette.xml.template
(Same change as for MPI-collective)
Comparison:
./compare_sim_outputs.py . /path/to/sequential/version/
The values in the output start to diverge after 36 coupling cycles.1
The maximum difference in the CSV files is 0.9154 (7%) for the macroscopic mass.
The maximum difference in the VTK files is 0.0027 (5%) for the Y-velocity.
Values in output are identical if 2-way coupling is disabled.
Footnotes
-
The error may result from the change in how the sum of values is obtained across instances, since floating point addition is not associative (see IEEE 754, Section 3.2 or the corresponding Wikipedia article) ↩
from mamico.
My suspicion is that the difference for dynamic MD ensembles is just attributable to the use of the MPI reduce operation. While Balaji and Kimpe 2013 mention that implementors are encouraged to take care not to introduce non-determinism between runs, this does not hold for collective vs. sequential implementation.
I've been testing using OpenMPI which assumes that the reduce operations are associative according to the section Predefined Reduce Operations in the documentation. (This is not the case for addition of floating point numbers)
When using the collective MPI methods only for broadcasting from macro to MD, there is no divergence which would support this hypothesis.
The coupling cycle after which a divergence (of 1e-7 for one cell and one value) of the results first occurs is also influenced by the value of the attribute reorganise-memory-every-timestep
of the node simulation-configuration
in the configuration, at least slightly. (Offset of 1 coupling cycle for a value of 10000000000000 instead of 20)
A visual inspection of the two versions after 50 coupling cycles using ParaView shows no discernible difference, although that is quite a weak test:
The difference between both images is indicated below in pink and is completely attributable to resizing artifacts.
from mamico.
Related Issues (20)
- Rename CouetteSolverInterface
- Config validation HOT 2
- Code file referenced in configuration templates
- Class diagrams in Doxygen
- MultiMDServiceTest::testAvgNumberOfMDSimulations does not run sequentially HOT 2
- Upload coverage data as artifact? HOT 1
- Refactor IndexingService::getUniqueRankForMacroscopicCell
- postMultiInstanceFilterPipeline not included in filtering runtime HOT 1
- IndexingServiceTest does not compile and a test fails in sequential HOT 1
- MultiMDCellService modifies MolecularDynamicsConfiguration HOT 1
- Refactoring during MaMiCo Coding Week February 2024 HOT 1
- Use valid XML for config files
- Move the defintion of the OpenFoam-installation-directory from couette.xml to a CMAKE-Flag
- Enhance Wiki/Documentation
- Collective MPI
- NaNs after ca. 220 coupling cycles HOT 1
- CI test ls1 files
- Excessive output by NLM filter
- SimpleMD fails during equ. with 120³ domain
- /examples 👉 /tools
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mamico.