application does not return non-zero code upon failure about docker_opencor_run_model HOT 6 CLOSED

Running w/ arguments runs through and returns exit code 0

$ docker run hsorby/opencor-python 1000.0
... [json result in stdout] ...
$ echo $?
1

I take it that this should read:

$ echo $?
0

And that the 1 is a typo?

If that is the case it looks like this is an upstream issue and I will pass it on.

from docker_opencor_run_model.

On second look this might be me. I'll try and find a return code and pass it up.

from docker_opencor_run_model.

And it turns out when passing up a return code the OpenCOR Python module is causing a segmentation fault which is an upstream problem.

I'll pass this one on.

from docker_opencor_run_model.

Running w/ arguments runs through and returns exit code 0

$ docker run hsorby/opencor-python 1000.0
... [json result in stdout] ...
$ echo $?
1

I take it that this should read:

$ echo $?
0

And that the 1 is a typo?

Running w/ arguments runs through and returns exit code 0

$ docker run hsorby/opencor-python 1000.0
... [json result in stdout] ...
$ echo $?
1

I take it that this should read:

$ echo $?
0

And that the 1 is a typo?

Yes, sorry, that was a typo :-) it returns 0

from docker_opencor_run_model.

Great, upstream issue is dbrnz/opencor#27

from docker_opencor_run_model.

Fixed in version 0.2.2 of the image.

from docker_opencor_run_model.