Git Product home page Git Product logo

Comments (5)

hsiafan avatar hsiafan commented on May 16, 2024

fixed in 9335b71

from apk-parser.

AndroidDeveloperLB avatar AndroidDeveloperLB commented on May 16, 2024

list of ProtectionLevel ?
Why not use EnumSet ? Seems like the best solution...
After all, a list can contain the same object multiple times...

from apk-parser.

hsiafan avatar hsiafan commented on May 16, 2024

This situation (add the same object multiple times) will not happean, the code(ProtectionLevel.valueOf) will add at most three distinct protect levels

from apk-parser.

AndroidDeveloperLB avatar AndroidDeveloperLB commented on May 16, 2024
  1. It doesn't matter. The best suited data structure is EnumSet, because of its content (which are enums).
  2. It doesn't make sense to have multiple enum values in this data structure. Same goes for the order of the items.
  3. Think what will happen in case the situation changes. You might not remember this in the future.
  4. It's more optimized than a list, or at least can be more optimized.
  5. I recommend you to watch a video of enum :
    https://www.youtube.com/watch?v=V1vQf4qyMXg

from apk-parser.

AndroidDeveloperLB avatar AndroidDeveloperLB commented on May 16, 2024

So I guess it wasn't changed to enumSet...

from apk-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.