Charset isn't set in ContentType about akka-http-json HOT 10 CLOSED

Very interesting! Let me play with this a little, which might take some time, because I'm on vacation.

from akka-http-json.

I've found that you can very simply solve this problem by specifying that the contentType of the HttpEntity be `application/json`.withParams(Map("charset" -> "utf-8")) instead of just `application/json`.

from akka-http-json.

Where? Client or server?

from akka-http-json.

On the server. Something like

val body = Foo("München").asJson.noSpaces
val entity = HttpEntity(`application/json`.withParams(Map("charset" -> "utf-8")), body)
complete(entity)

from akka-http-json.

After reading up on JSON (e.g. RFC 7159 and SO) I think that the current implementation is just fine, because application/json is defined as MediaType.WithFixedCharset (of course UTF-8 is used) and UTF-8 is defined as the default encoding for JSON, hence setting the charset in the response header explicitly is redundant. The client needs to be changed to assume UTF-8 if not indicated otherwise.

from akka-http-json.

I see your points, however, I'm not sure if that's the way it should be dealt with. I don't think we can change browser internals to assume UTF-8 (maybe there's something I don't know about, the only thing I can think about is add a request header to accept utf-8 only).
Moreover, if I look at any other public api out there they all include the response header Content-Type: application/json; charset=utf-8, I concur that "all the others do it" is not the greatest argument, but I believe it shouldn't stray to far from the others for the sake of compatibility.

from akka-http-json.

You're speaking about a browser, but browsers are for HTML. Have you tried your example with a HTTP client, e.g. curl or httpie?

The closest others in this case are Akka and the other libraries supporting JSON encoding. AFAIK none sends that header.

from akka-http-json.

I tried to reproduce this issue but could not. Neither with httpie nor with Safari.

Now here's a rude assumption: when you implemented the server, are you sure the source files are UTF-8 encoded? Please double check.

from akka-http-json.

Sorry for getting back to you late, I was on vacation as well.
Now here's something odd, I double checked the encoding of the source file and it is indeed UTF-8, however I checked again with httpie and this time it seems to have worked, even though I could have sworn it did not the last time I tried. Browser(Chrome) still gives me wrong answer though. I concur with your point that they are for HTML. I was assigned to fix the issue by a colleague of mine, so I'm going to have to check with him for which client he was using. Thanks again for your time! :)

from akka-http-json.

No worries. It was quite educational.

from akka-http-json.