Undefined exports: expand_scale about hrbrthemes HOT 8 CLOSED

it may work if load ggplot2 before you install/update it but that might not be possible with devtools::update_packages() if you use dev versions of ggplot2.

i'm trying to compensate for an error in the way ggplot2 specifies function links.

I do: https://github.com/hrbrmstr/hrbrthemes/blob/master/R/scales.r#L13 to avoid having to replicate the docs in ggplot2 scales but b/c of https://github.com/tidyverse/ggplot2/blob/4255cd8341ad1072036186e5d34ad2c1b12221b3/R/scale-discrete-.r#L12 it fails miserably. I'm not inclined to replicate the scales docs, but i agree this def needs to be kept open since this won't get to CRAN the way I've got it.

i was avoiding just making a local "alias" for the ggplot2 function b/c then i have to declare all the stuff i use from ggplot2 but that may make more sense now due to this issue.

i'll poke at it and really appreciate this report as i wld not have seen it on my end.

from hrbrthemes.

I just pushed up what I'm hoping is a quick fix (as I didn't get any errors on my end and the README + test suite works fine). Give it a go when you get a chance pls.

from hrbrthemes.

Thanks for the quick response. This results in a different error: 'expand_scale' is not an exported object from 'namespace:ggplot2'. This occurs immediately after ** preparing package for lazy loading, whereas before, devtools would install the help and vignettes, and then error out at ** testing if installed package can be loaded. Let me know if there's any other information that would be useful.

from hrbrthemes.

This is super helpful. Are you running CRAN ggplot2 or GH? I think the issue is it's exported in GH ggplot2 (https://github.com/tidyverse/ggplot2/blob/master/NAMESPACE#L275) but not CRAN ggplot2

from hrbrthemes.

ok, i bit the bullet and just reproduced the roxygen docs. can you give it a go(as you have time) and also make sure i got your details right in the DESCRIPTION file? (this has been rly rly helpful and I'd like to add you as a contributor)

from hrbrthemes.

Yes, running CRAN ggplot2. Reproducing the oxygen docs seems to have worked; installation is successful, and the package loads as expected. Out of curiosity, what made you decide to reproduce, rather than require GH ggplot2?

Thanks again for responding so quickly, and for offering to list me as a contributor. Yes, details are correct. 👍

from hrbrthemes.

from hrbrthemes.

Glad it was helpful. I really appreciate you making it so easy to make great looking plots!

from hrbrthemes.