Comments (8)
LGTM! 🚢 it!
from hrbrthemes.
thx for testing! I'll wait til the other voluntary Windows person cough @davidski cough tests it and close it after.
from hrbrthemes.
I--Windows user -- ran into the same problem and found this thread, and it solved the problem beautifully!! Thanks Mr.Rudis for making this package!
from hrbrthemes.
i have to noodle a bit on this one. generally, one has to do this (use extrafont to load fonts for PDF and PostScript) for any non-core font for those devices (they have no impact on bitmap devices like PNG and shld not have any bearing on the svglite device). For someone like myself with an insane amount of fonts on his system, I loadfonts
introduces a very noticeable delay and i only do it for work projects that need PDF output (which is about 8x a year).
if i added an option check (i.e. test for hrbrloadfonts
) then that's an extra bit of code folks have to run anyway vs just use an extra line of code (or 2) to do the loadfonts
.
Perhaps @bhaskarvk & @davidski can toss some opines here regarding ^^l
from hrbrthemes.
Unfortunately, loadfonts
is required to make fonts available even to the Windows bitmap device. Without attaching extrafont
, theme_ipsum_rc
will still fail to use the correct font and throw warnings on Windows.
I've also struggled with the "to load extrafont or not to load" question and and currently am doing an attachment in my code. My audience is far smaller and narrower, so simply documenting that library(extrafont)
is required for Windows users may be a good choice for now.
from hrbrthemes.
from hrbrthemes.
the update I just made shld take care of this. I tried a compromise solution to both Windows and PDF/PS fonts. Win is autoloaded (since I'll never have to deal with that :-) and i made a global pkg option for the PDF/PS load. Also added a font presence check on pkg startup.
from hrbrthemes.
working perfectly for me. (btw most of us blame our employers for the windows situation...)
thanks for such prompt attention to an issue that doesn't affect you!
from hrbrthemes.
Related Issues (20)
- Dark (FT) Roboto RMarkdown template
- Install errors HOT 2
- More thorough font installation/config documentation & helpers HOT 5
- The example charts contain a different fill than the defaults HOT 1
- Gridlines and Grid Labels are Out of Alignment HOT 1
- Gridlines and Axis Labels are Out of Alignment HOT 1
- theme_ipsun fonts not working HOT 1
- Dot Plots in hrbrthemes HOT 5
- Error: lazy-load database ... hrbrthemes.rdb' is corrupt HOT 2
- Unable to export to pdf for some fonts HOT 1
- Broken image gallery HOT 1
- theme_modern_rc() overwrites default point color HOT 1
- supporting applying `hrbrthemes` themes to labels in `ggplot2` HOT 1
- systemfonts package not gett HOT 2
- **CLOSE** Mac Change Font Family HOT 3
- Missing images on doc site? HOT 1
- gdtools dependency/suggests no more needed HOT 1
- hrbrthemes::theme_ipsum_rc(), issue HOT 2
- Change to new cran checks badge URL HOT 1
- Found a typo in pkgdown
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hrbrthemes.