Git Product home page Git Product logo

Comments (8)

davidski avatar davidski commented on September 12, 2024 3

LGTM! 🚢 it!

from hrbrthemes.

hrbrmstr avatar hrbrmstr commented on September 12, 2024 1

thx for testing! I'll wait til the other voluntary Windows person cough @davidski cough tests it and close it after.

from hrbrthemes.

grepinsight avatar grepinsight commented on September 12, 2024 1

I--Windows user -- ran into the same problem and found this thread, and it solved the problem beautifully!! Thanks Mr.Rudis for making this package!

from hrbrthemes.

hrbrmstr avatar hrbrmstr commented on September 12, 2024

i have to noodle a bit on this one. generally, one has to do this (use extrafont to load fonts for PDF and PostScript) for any non-core font for those devices (they have no impact on bitmap devices like PNG and shld not have any bearing on the svglite device). For someone like myself with an insane amount of fonts on his system, I loadfonts introduces a very noticeable delay and i only do it for work projects that need PDF output (which is about 8x a year).

if i added an option check (i.e. test for hrbrloadfonts) then that's an extra bit of code folks have to run anyway vs just use an extra line of code (or 2) to do the loadfonts.

Perhaps @bhaskarvk & @davidski can toss some opines here regarding ^^l

from hrbrthemes.

davidski avatar davidski commented on September 12, 2024

Unfortunately, loadfonts is required to make fonts available even to the Windows bitmap device. Without attaching extrafont, theme_ipsum_rc will still fail to use the correct font and throw warnings on Windows.

I've also struggled with the "to load extrafont or not to load" question and and currently am doing an attachment in my code. My audience is far smaller and narrower, so simply documenting that library(extrafont) is required for Windows users may be a good choice for now.

from hrbrthemes.

hrbrmstr avatar hrbrmstr commented on September 12, 2024

from hrbrthemes.

hrbrmstr avatar hrbrmstr commented on September 12, 2024

the update I just made shld take care of this. I tried a compromise solution to both Windows and PDF/PS fonts. Win is autoloaded (since I'll never have to deal with that :-) and i made a global pkg option for the PDF/PS load. Also added a font presence check on pkg startup.

from hrbrthemes.

alexwhan avatar alexwhan commented on September 12, 2024

working perfectly for me. (btw most of us blame our employers for the windows situation...)
thanks for such prompt attention to an issue that doesn't affect you!

from hrbrthemes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.