Git Product home page Git Product logo

Comments (4)

nilnor avatar nilnor commented on June 14, 2024

The two above examples are actually separate. in the first one the icon file can't be found. Something to do with your installation and/or how the root dir is found. Would be great if you could add some printouts to Application._load_application_icon and have a look at where it attempts to find the file, and then we can figure out what the error is.

The second I presume has something to do with SVG support on OS X, will search around some for that one.

from howl.

refi64 avatar refi64 commented on June 14, 2024

If I put a print in application.moon here:

    for dir in *{ @root_dir.parent, @root_dir }
      print "icon: #{dir}"
      icon = dir\join('share/icons/hicolor/scalable/apps/howl.svg')
      if icon.exists
        status, err = pcall Gtk.Window.set_default_icon_from_file, icon.path
        log.error "Failed to load application icon: #{err}" unless status
        return

It prints:

icon: /usr/local/share
icon: /usr/local/share/howl

I'm guessing either:

  1. Howl should also search @root_dir.parent.parent.
  2. The line icon = dir\join('share/icons/hicolor/scalable/apps/howl.svg') should be changed to icon = dir\join('icons/hicolor/scalable/apps/howl.svg').

from howl.

nilnor avatar nilnor commented on June 14, 2024

I went for a variant of 1. 2 wouldn't work, since we want to support both running it from a globally installed version and running it directly from the checkout.

from howl.

refi64 avatar refi64 commented on June 14, 2024

@nilnor Thanks!

from howl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.