Comments (6)
@ocBruno unless there is a compelling reason to not use the built in bootstrap validation styling, I think that we should use that.
from components.
@irvelervel Can you provide any direction/best practice about this topic?
from components.
Happy to give this one a go! I'd like to follow React Bootstrap as a basis and try to help the look and feel as hospitalrun as possible. Is there a styleguide or any kind of branding guideline that I should lean on here?
from components.
Hey @adamdickinson I thought i'd give this a go since I saw it's been inactive but if you're still working on this give me a heads up!
I'm searching for validation best practices and will try to focus more on the usability and design while avoiding inserting too much logic inside the components.
Is formik a viable option or would it require too much refactoring?
I was thinking using schemas as shown here might be a good validation technique.
https://react-bootstrap.github.io/components/forms/#forms-validation-libraries
@jackcmeyer Shall I implement this library or attempt to create something custom?
If anyone has any best practices, suggestions, or any requests I'm always looking for improvements and mistakes I might have overlooked!
from components.
@ocBruno unless there is a compelling reason to not use the built in bootstrap validation styling, I think that we should use that.
Ah pardon me I got offtrack, I was thinking of another issue considering how to handle the validation. If anyone has any suggestions or feedback on the program and grafic design send me a reply!
Also this next commit I pushed I'm uncertain what is the ideal way to modify the style of the react bootstrap select component so I can add a margin to the exclamation mark if anyone has any ideas on the ideal pattern.
Currently working on improving the design of and styling the input components, and inserting custom validation messages.
from components.
🎉 This issue has been resolved in version 1.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from components.
Related Issues (20)
- Type '{ children: string; eventKey: string; }' is not assignable to type 'IntrinsicAttributes & Props'. HOT 1
- Add Logout icon HOT 4
- How Observable call HOT 1
- New Patient Icons HOT 9
- Select should show all options when opened regardless of filter HOT 6
- Any NavLink label should be able to be any React component HOT 6
- Add markdown support on homepages of Storybook HOT 9
- Provide callbacks for filter/search capabilities on table column HOT 16
- Table component should use generics HOT 3
- Callout css does not work when importing to frontend HOT 9
- Basic authentication prompt HOT 12
- v2.0.1 fails build of @hospitalrun/frontend HOT 4
- Modal Dialog Form: UX improvements relating to closing of component HOT 1
- Add Integration Testing during build pipeline
- Upgrade to React 17.0.x HOT 8
- Add Billing and Inventory icons HOT 2
- Add a billing icon HOT 4
- Add an inventory icon HOT 8
- Add tests and Storybook components for arrow icons HOT 3
- Select - add the ability to display error messages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from components.