Git Product home page Git Product logo

Comments (7)

cvaldev avatar cvaldev commented on August 25, 2024

Hi, I'd love to contribute to this if that's ok. It'd be my first time working on this project, but I took a look around to get an idea of the process. I'd like to make sure I understand what's needed to solve this issue, feel free to correct me if this is wrong:

  1. Add className and style props to each component.
  2. Add a story and test for className per component.
  3. Add a story and test for style per component.
  4. Edit the docs (is this automated?)

from components.

jackcmeyer avatar jackcmeyer commented on August 25, 2024

You got it @CVVPK! I've assigned this to you.

from components.

fox1t avatar fox1t commented on August 25, 2024

Hi @CVVPK and thanks for contributing!
All of your assumptions are correct. For the 4th point, you just have to comment the code in the right way and it will be generated for you. Just take a look at the comments that are already there. :)

from components.

cvaldev avatar cvaldev commented on August 25, 2024

@jackcmeyer The number of changes is getting pretty massive and I was wondering if you'd prefer I submit individual PRs or everything in one big chunk. Here's a status report of my progress so far:

Completed:

  • Alert
  • Badge
  • Breadcrumb
  • BreadcrumbItem
  • Button
  • Icon
  • Label
  • List
  • ListItem
  • Pill
  • Radio
  • Select
  • Switch
  • TextField
  • TextInput
  • Checkbox
  • Layout

To do:

  • Navbar (In progress...)
  • Image (?)
  • DateTimePicker (?)
  • Modal (?)
  • Toaster (?)
  • Graph (Unsure if required)
  • Spinner (Unsure if required)
  • VideoPlayer (Unsure if required)
  • RichText (Unable to add the props to current implementation)
  • Calendar (Unable to add the props to current implementation)

I have some question regarding the following ones:

  1. Image:
  • Already able to receive the props implicitly through imgAttributes, should we make it explicit?
  1. DateTimePicker:
  • #159 added className for InputGroup, should className be added for the DatePicker?
  1. Modal:
  • A Modal could have three different buttons, do we want to style each of them individually?
  • A Modal could have a header, body and footer, do we want to style each of them individually?

from components.

jackcmeyer avatar jackcmeyer commented on August 25, 2024

@CVVPK feel free to open as many or few pull requests as you want! Whatever is easiest for you!

from components.

 avatar commented on August 25, 2024

🎉 This issue has been resolved in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from components.

 avatar commented on August 25, 2024

🎉 This issue has been resolved in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.