Comments (7)
Hi, I'd love to contribute to this if that's ok. It'd be my first time working on this project, but I took a look around to get an idea of the process. I'd like to make sure I understand what's needed to solve this issue, feel free to correct me if this is wrong:
- Add
className
andstyle
props to each component. - Add a story and test for
className
per component. - Add a story and test for
style
per component. - Edit the docs (is this automated?)
from components.
You got it @CVVPK! I've assigned this to you.
from components.
Hi @CVVPK and thanks for contributing!
All of your assumptions are correct. For the 4th point, you just have to comment the code in the right way and it will be generated for you. Just take a look at the comments that are already there. :)
from components.
@jackcmeyer The number of changes is getting pretty massive and I was wondering if you'd prefer I submit individual PRs or everything in one big chunk. Here's a status report of my progress so far:
Completed:
- Alert
- Badge
- Breadcrumb
- BreadcrumbItem
- Button
- Icon
- Label
- List
- ListItem
- Pill
- Radio
- Select
- Switch
- TextField
- TextInput
- Checkbox
- Layout
To do:
- Navbar (In progress...)
- Image (?)
- DateTimePicker (?)
- Modal (?)
- Toaster (?)
- Graph (Unsure if required)
- Spinner (Unsure if required)
- VideoPlayer (Unsure if required)
- RichText (Unable to add the props to current implementation)
- Calendar (Unable to add the props to current implementation)
I have some question regarding the following ones:
- Image:
- Already able to receive the props implicitly through
imgAttributes
, should we make it explicit?
- DateTimePicker:
- #159 added
className
forInputGroup
, shouldclassName
be added for theDatePicker
?
- Modal:
- A
Modal
could have three different buttons, do we want to style each of them individually? - A
Modal
could have a header, body and footer, do we want to style each of them individually?
from components.
@CVVPK feel free to open as many or few pull requests as you want! Whatever is easiest for you!
from components.
🎉 This issue has been resolved in version 0.23.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from components.
🎉 This issue has been resolved in version 0.27.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from components.
Related Issues (20)
- Type '{ children: string; eventKey: string; }' is not assignable to type 'IntrinsicAttributes & Props'. HOT 1
- Add Logout icon HOT 4
- How Observable call HOT 1
- New Patient Icons HOT 9
- Select should show all options when opened regardless of filter HOT 6
- Any NavLink label should be able to be any React component HOT 6
- Add markdown support on homepages of Storybook HOT 9
- Provide callbacks for filter/search capabilities on table column HOT 16
- Table component should use generics HOT 3
- Callout css does not work when importing to frontend HOT 9
- Basic authentication prompt HOT 12
- v2.0.1 fails build of @hospitalrun/frontend HOT 4
- Modal Dialog Form: UX improvements relating to closing of component HOT 1
- Add Integration Testing during build pipeline
- Upgrade to React 17.0.x HOT 8
- Add Billing and Inventory icons HOT 2
- Add a billing icon HOT 4
- Add an inventory icon HOT 8
- Add tests and Storybook components for arrow icons HOT 3
- Select - add the ability to display error messages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from components.