Git Product home page Git Product logo

Comments (7)

Hookyns avatar Hookyns commented on August 31, 2024 1

I think I know what is going on.
You can try to fix, if you want. 🙂 I'm off for today...

The arrays are the same ts.Symbol probably so they have the same id.

tst-reflect/transformer/src/helpers.ts

Lines 118 to 128 in f835710

export function getTypeId(type: ts.Type, typeChecker: ts.TypeChecker): number | undefined
{
const symbol = getTypeSymbol(type, typeChecker);
if (symbol == undefined)
{
return;
}
return getSymbolId(symbol);
}

In the new version I use type.id, not symbol.id, it should fix this issue, but it may cause other issues... Not every symbol has id but every type has. Only types with Id are stored, others are inlined... but it may not be an issue, but it will generate bigger metadata.

from tst-reflect.

bjsi avatar bjsi commented on August 31, 2024 1

Thanks, I'll play around and see if I can fix.

from tst-reflect.

Hookyns avatar Hookyns commented on August 31, 2024 1

I'm working on it.

Return type's id instead of symbol's id is not enough. I've made several other changes to make it work, everything seems alright but two tests are failing. Those tests seems unrelated to this but idk there must be something,.. I'm trying to solve that.

from tst-reflect.

Hookyns avatar Hookyns commented on August 31, 2024 1

Solved.

I've published [email protected].

from tst-reflect.

bjsi avatar bjsi commented on August 31, 2024 1

Awesome, looks like the issue is fixed for me!

from tst-reflect.

Hookyns avatar Hookyns commented on August 31, 2024

@all-contributors please add @bjsi for bug report

from tst-reflect.

allcontributors avatar allcontributors commented on August 31, 2024

@Hookyns

I've put up a pull request to add @bjsi! 🎉

from tst-reflect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.