Git Product home page Git Product logo

Comments (5)

balloob avatar balloob commented on May 24, 2024

It looks like Netdisco will end up with a collection of all the poor engineering choises in the world 😢

Anyway, you're right in not hacking SSDP but add it as a standalone. Make sure it is clearly described why it is not inside SSDP in the module description . Also remove all reference to the name SSDP to prevent confusion.

from netdisco.

balloob avatar balloob commented on May 24, 2024

It should also not re-use any SSDP discoverable etc

from netdisco.

rytilahti avatar rytilahti commented on May 24, 2024

I created #77 which uses mDNS instead of SSDP. This however doesn't allow detecting the supported features among other metadata which is sadly available only through SSDP.

from netdisco.

jjensn avatar jjensn commented on May 24, 2024

I think your changes are far more elegant than mine. The Yeelight python module that does the heavy lifting queries the bulb API, so I don't think it matters if the discovery part doesnt get a list of features

from netdisco.

rytilahti avatar rytilahti commented on May 24, 2024

Agreed, we can let the library do that. We can get the type of the bulb from its hostname which is now reported onwards.

from netdisco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.