Git Product home page Git Product logo

Comments (14)

cherrynoize avatar cherrynoize commented on May 15, 2024

I get the same result using upscayl-realesrgan-x4plus-anime too.

from upscaler.

hollowaykeanho avatar hollowaykeanho commented on May 15, 2024

So at least I would like to point out that there's some issues with saving the output image, as by default with param --input image.jpg I would get an error for it tries to save to image.jpg/image-upscaled.jpg (which is clearly not what's expected). Specifying --output per se does not solve the issue but I found that --input ./image.jpg --output ./image-upscaled.jpg (and probably omitting output too) works around the issue. Though it does seem to ignore the --output param completely.

Hi @cherrynoize , sorry for the buggy powershell scripting. As a matter of fact, I am working on it but in a separate project repository (since it's rare to find a tested posixshell+powershell standard library). Appreciate your patience.

FYI, next release would be the last one using Shell script wrapping method as I will personally go into the C & C++ codes to make everything scratch.


111044966_p0_master1200-wm_rm-upscaled
I get this.

This can be caused by 2 issues:

  1. The input image has an AI poisoning data in it.
  2. Model faulty. You can choose other model. I personally use upscayl-nmkd-4x-superscale-sd-178000-g (next release or git clone the repo), upscayl-remacri, upscayl-ultramix_balanced, and lastly upscayl-ultrasharp-v2.

from upscaler.

Joly0 avatar Joly0 commented on May 15, 2024

Really appreciate someone putting some effort into a CLI version for this. I would love to work on some PRs myself but I just don't have the time right now.

So at least I would like to point out that there's some issues with saving the output image, as by default with param --input image.jpg I would get an error for it tries to save to image.jpg/image-upscaled.jpg (which is clearly not what's expected). Specifying --output per se does not solve the issue but I found that --input ./image.jpg --output ./image-upscaled.jpg (and probably omitting output too) works around the issue. Though it does seem to ignore the --output param completely.

Hm, that is really odd behaviour. I´ll look into it and try to fix it :)

from upscaler.

cherrynoize avatar cherrynoize commented on May 15, 2024

That would be great. BTW, I thought I had answered to @hollowaykeanho mentioning I wasn't on Windows so I didn't think any powershell scripting would be the issue here.

from upscaler.

Joly0 avatar Joly0 commented on May 15, 2024

That would be great. BTW, I thought I had answered to @hollowaykeanho mentioning I wasn't on Windows so I didn't think any powershell scripting would be the issue here.

So you arent running this on windows but on linux? If yes, then this is not an issue for me, but for @hollowaykeanho

from upscaler.

uq1 avatar uq1 commented on May 15, 2024

I am having the same issue with the squares being random in the image. It does not happen on every run, but it seems to happen a lot.

I have tried about 6 models and they all seem to do the same thing, so it does not seem to be a model issue.

Image poisoning is somewhat impossible as these are textures from a 20 year old game.

Could this simply be some issue in the image save function? The squares in the image look ok, just not in the right location in the over-all picture.

Here's another example:
aurora2_upscaled

from upscaler.

hollowaykeanho avatar hollowaykeanho commented on May 15, 2024

Could this simply be some issue in the image save function? The squares in the image look ok, just not in the right location in the over-all picture.

Here's another example:
aurora2_upscaled

Wow. This is definitely the first case I've seen. @cherrynoize, and @uq1, can both of you send me a the original image to be included in the test suite please? I will analyze it.

@Joly0, no worries. Please work on the parallel execution task ya. =) I will triage the case.

Apologize for this the late responsiveness. Am currently involved in a client's project. Will patch the software in and out.

from upscaler.

uq1 avatar uq1 commented on May 15, 2024

No problems, here's the original.

aurora2

from upscaler.

uq1 avatar uq1 commented on May 15, 2024

FYI: I just upscaled the same image again and this time it worked fine. The original was being called through a game, while this time I tried it just from command prompt. Could other processes CPU/GPU usage be affecting it?

I hope this insight helps.

from upscaler.

hollowaykeanho avatar hollowaykeanho commented on May 15, 2024

@uq1 , not an issue here. It should lower level like drivers or hardware. I'm incline to former.

sample-03_upscaled

from upscaler.

hollowaykeanho avatar hollowaykeanho commented on May 15, 2024

Yeah... same case for the Ubuntu (I'm on Debian). It should be related to either model or low level driver before we arrive to hardware (@uq1 , your case is very unlikely a hardware problem). Ubuntu is known for heavy modifications for better user experience.

sample-04_upscaled

from upscaler.

hollowaykeanho avatar hollowaykeanho commented on May 15, 2024

Help wanted to further root cause the problem. In the meantime, I do what I can to provide workaround for this weird bug.

from upscaler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.