Git Product home page Git Product logo

Comments (2)

Hoffs avatar Hoffs commented on June 7, 2024 1

I am not 100% now, since it's been a while since I worked on this, but if the buffer is not attached to LSP client, then no LSP commands will work. To begin with, it uses clients that are attached to current buffer at the start of lsp_definitions. Then, if I am not mistaken, the file is loaded using LSP protocol to the LSP server, so when any command is executed in the file at certain position, LSP server has to have this file loaded. So for metadata files this maybe could be circumvented, by explicitly going with 'o#/v2/gotodefinition call, instead of regular LSP textDocument/definition.

So overall, I believe it is not as simple as not attaching the client to the buffer, as that breaks definition lookup from inside metadata files. It maybe could be worked around by using custom command and not lsp handler, but at this moment I haven't felt that current behavior causes me issues, so I don't feel like spending time on this.

from omnisharp-extended-lsp.nvim.

hoelter avatar hoelter commented on June 7, 2024

I appreciate your thoughts on this. I haven't felt a need for definition lookups inside the metadata file since disabling LSP on them, but if I change my mind and spend time on getting it working like you're suggesting I'll submit a PR. Thanks again for creating this plugin and putting it out into the world!

from omnisharp-extended-lsp.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.