I'm using this library outside play, and I would really like not to have to include th

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I suspect that it's the type of the lazy val at <a href="https://github.com/hmrc/email

Remove dependency on play-json about emailaddress HOT 4 CLOSED

hmrc commented on September 4, 2024

Remove dependency on play-json

from emailaddress.

Comments (4)

duncancrawford commented on September 4, 2024

@mgladdish please feel free to submit a PR. Currently play-json is added for the Reads[EmailAddress] & Writes[EmailAddress] impls, re. https://github.com/hmrc/emailaddress/blob/master/src/main/scala/uk/gov/hmrc/emailaddress/EmailAddress.scala#L25

from emailaddress.

howyp commented on September 4, 2024

It's a provided dependency, so it shouldn't be required unless you want to use the formats.

Having said that, I suspect there may be an issue with the object initialisation that stops the library from working without play. I'll try and look at this later - do you experience that?

from emailaddress.

mgladdish commented on September 4, 2024

Yes, that’s the issue; I’ve already tried using it without the optional dependency. Even though the format member is lazy, the class loader still attempts to reference all, er, references.

from emailaddress.

howyp commented on September 4, 2024

I suspect that it's the type of the lazy val at https://github.com/hmrc/emailaddress/blob/master/src/main/scala/uk/gov/hmrc/emailaddress/EmailAddress.scala#L22 that's causing the classloader to try to load Play classes. I can't look at this now but will try to come up with a fix later today or tomorrow.

from emailaddress.

Recommend Projects