Git Product home page Git Product logo

Comments (7)

KennethEnevoldsen avatar KennethEnevoldsen commented on June 2, 2024 1

It would be (but you could quite often miss a few places. This allows for mistakes while still allowing the user to figure out what the valid metrics are (It also allows user to add their own metrics).

Which metrics to extract. Could for example include one or more of [“descriptive_stats”, “readability”, “dependency_distance”, “pos_proportions”, “coherence”, “quality”]. To see the full list available metrics see td.get_valid_metrics(). If None, will extract all metrics from textdescriptives. Defaults to None.

from textdescriptives.

KennethEnevoldsen avatar KennethEnevoldsen commented on June 2, 2024 1

But we should def. just update the docstring to be the same.

from textdescriptives.

HLasse avatar HLasse commented on June 2, 2024

Perhaps we should refer to the textdescriptives.utils.get_valid_metrics function?

from textdescriptives.

LudvigOlsen avatar LudvigOlsen commented on June 2, 2024

You mean it's better to automate updating this than going through it manually every now and then when someone makes an issue?

Do you know how to generate parts of docstrings dynamically? I haven't tried that before.

from textdescriptives.

KennethEnevoldsen avatar KennethEnevoldsen commented on June 2, 2024

I think lasse means that we can update the docs from:

Which metrics to extract. One or more of [“descriptive_stats”, “readability”, “dependency_distance”, “pos_proportions”, “coherence”, “quality”]. If None, will extract all metrics from textdescriptives. Defaults to None.

to:

Which metrics to extract. Could for example include one or more of [“descriptive_stats”, “readability”, “dependency_distance”, “pos_proportions”, “coherence”, “quality”]. To see the full list available metrics see `td.get_valid_metrics()`. If None, will extract all metrics from textdescriptives. Defaults to None.

from textdescriptives.

KennethEnevoldsen avatar KennethEnevoldsen commented on June 2, 2024

The metrics are already all available in the get_valid_metrics and will be updated automatically when new components are added as the use the registries from spacy.

from textdescriptives.

LudvigOlsen avatar LudvigOlsen commented on June 2, 2024

How often do you add metrics? Shouldn't it be possible to manually update it? Search for one of the metrics in the repo and add it everywhere. But yes, having it as an extra (in case docs aren't updated, look here) thing, seems fine. Autogenerating that part of the docstring (if possible) also seems fine though.

from textdescriptives.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.