Highlight colors are not saved in VS2015 about asm-dude HOT 21 CLOSED

and vs 2017 15.5.0

• Please don‘t use blue for the default color，It's too blue in the dark theme（：

from asm-dude.

Turns out Asm Dude keeps two sets of colors for highlighting:

• one in the "AsmDude" page of the Options dialog (as far as I can tell these colors are ignored).
• one in the Environment -> Fonts and Colors page (these are actually used).
  Why the unused colors?
  And how can I make the font not italic?

from asm-dude.

I'll look into it.

Can you recall when this behaviour first occurred, was this bug introduced in the last release?

from asm-dude.

I can't tell when this was introduced. I just installed the addon.

from asm-dude.

You will need to restart VS for these changes to be picked up. Have you restarted VS?

from asm-dude.

Yes, I had restarted it. No effect.
I just tried again with a new color that I configured in Options -> AsmDude -> General. When I closed the dialog with "OK" it asked for a restart. I restarted VS and again the color I had just set it ignored. The colors actually used are those in Options -> Environment -> Fonts and Color -> Display Items -> AsmDude-XXX.

from asm-dude.

You are right, VS2015 does not save the these options to the properties you mentioned (Options -> Environment -> Fonts and Color -> Display Items -> AsmDude-XXX). VS2017 works fine. For the time being you could edit the AsmDude-XXX values.

from asm-dude.

@adigostin, I've release a new version (1.7.3.5) in which I cannot reproduce the issue in which the colours are not saved.

Could you please try this new version and check whether you still have that problem in VS2015.

from asm-dude.

I'm not sure what you changed in 1.7.3.5, cause the issue seems to still be there. See the screenshot below; that's after a VS restart.
What has changed in 1.7.3.5 (i.m.o. for the better) is the font, which used to be italic and now it's not.

(Why not remove those color settings altogether? The AsmDude-XXX colors seem to do the job well, and they don't need VS to be restarted.)

from asm-dude.

I'll need to check this on a fresh machine.

from asm-dude.

In my PC change color directive work.

from asm-dude.

@francescogomez Do you use VS2015 or VS2017 RC?

from asm-dude.

@HJLebbink VS2017 RC

from asm-dude.

Was looking into this bug. I uninstalled ASMDude and reinstalled it. Colors updated to the preferences I wanted.

from asm-dude.

@lazerzes To help me reproduce this, which version of AsmDude and VS did you use? Did you download an installer (from GitHub) or did you use the extension installer embedded in VS?

from asm-dude.

Using VS2015(w/ Update 3 idk if that matters.)

I used the Marketplace link with version 1.7.3.10 of AsmDude.
I have duplicated it on multiple machines at this point as well.

from asm-dude.

I have the same problem with the last release in VS 2015:

from asm-dude.

I have the same problem

from asm-dude.

I just installed v1.9.2.0 of asm-dude from Visual Studio Marketplace running on VS2017 15.3.4 and I am also experiencing colors not being saved. Other settings are saving such as I turned off Keyword Highlighting for Backgound and Border but could not get the colors to change.

from asm-dude.

I'm (still) working on a fix. (You could add a bounty to this question, I may help... https://stackoverflow.com/questions/47956223/how-to-change-a-classificationformatdefinition)

@stonedreamforest and @artemisart If you have a color scheme that works for both the dark theme and the regular theme, I will make it the default.

from asm-dude.

Hopefully fixed this bug in version 1.9.3.6. MEF components are cached and only refreshed when windows is restarted, and not always when VS is restarted. The bugfix is flushing this cache. Hopefully this has fixed your bug, it at least has fixed it for me, for the moment...

from asm-dude.