"ignoreFailures false" does not stop the build about license-gradle-plugin HOT 8 CLOSED

:cas-server-webapp:licenseTest
Missing header in: cas-server-webapp\src\test\java\org\jasig\cas\WiringTests.java
:cas-server-webapp:test
:cas-server-webapp:check

BUILD SUCCESSFUL

from license-gradle-plugin.

Any chance that this bug will be fixed?

from license-gradle-plugin.

I don't see what a checkstyle configuration has to do with the license-gradle-plugin. Is there an example of ignore failures not working with this plugin?

from license-gradle-plugin.

Sorry for the confusion. Although the description in the first post is wrong, the problem explained in the second post still exists. I assembled a small demo project which shows the problem:
https://dl.dropboxusercontent.com/u/36689039/license-plugin-test.zip

Simply run ./gradlew build. You'll see the following:

The TaskContainer.add() method has been deprecated and is scheduled to be removed in Gradle 2.0. Please use the create() method instead.
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar UP-TO-DATE
:assemble UP-TO-DATE
:licenseMain
Missing header in: src/main/java/LicenseHeaderTest.java
:licenseTest UP-TO-DATE
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:check
:build

BUILD SUCCESSFUL

The build doesn't stop with failure although LicenseHeaderTest.java has no valid header. build.gradle contains:

license {
  ignoreFailures false
  strictCheck true
  skipExistingHeaders true
}

from license-gradle-plugin.

I believe I fixed this in #15, but as far as I can tell that version was never released.
The current master version doesn't work for me, failing with the following stacktrace:

Caused by: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: org.gradle.api.tasks.TaskExecutionException(org.codehaus.groovy.runtime.GStringImpl)
    at nl.javadude.gradle.plugins.license.License.process(License.groovy:101)
    at org.gradle.api.internal.BeanDynamicObject$MetaClassAdapter.invokeMethod(BeanDynamicObject.java:196)
    at org.gradle.api.internal.BeanDynamicObject.invokeMethod(BeanDynamicObject.java:102)
    at org.gradle.api.internal.CompositeDynamicObject.invokeMethod(CompositeDynamicObject.java:99)
    at nl.javadude.gradle.plugins.license.License_Decorated.invokeMethod(Unknown Source)
    at org.gradle.util.ReflectionUtil.invoke(ReflectionUtil.groovy:23)
    at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$4.execute(AnnotationProcessingTaskFactory.java:150)
    at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$4.execute(AnnotationProcessingTaskFactory.java:145)
    at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:477)
    at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:466)
    at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:60)
    ... 56 more

Perhaps changing the TaskExecutionException thrown in nl.javadude.gradle.plugins.license.License back to a GradleException would fix it.

from license-gradle-plugin.

I'll have a look tomorrow.

2014/1/16 David M. Carr [email protected]

I believe I fixed this in #15#15,
but as far as I can tell that version was never released.
The current master version doesn't work for me, failing with the following
stacktrace:

Caused by: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: org.gradle.api.tasks.TaskExecutionException(org.codehaus.groovy.runtime.GStringImpl)
at nl.javadude.gradle.plugins.license.License.process(License.groovy:101)
at org.gradle.api.internal.BeanDynamicObject$MetaClassAdapter.invokeMethod(BeanDynamicObject.java:196)
at org.gradle.api.internal.BeanDynamicObject.invokeMethod(BeanDynamicObject.java:102)
at org.gradle.api.internal.CompositeDynamicObject.invokeMethod(CompositeDynamicObject.java:99)
at nl.javadude.gradle.plugins.license.License_Decorated.invokeMethod(Unknown Source)
at org.gradle.util.ReflectionUtil.invoke(ReflectionUtil.groovy:23)
at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$4.execute(AnnotationProcessingTaskFactory.java:150)
at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$4.execute(AnnotationProcessingTaskFactory.java:145)
at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:477)
at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:466)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:60)
... 56 more

Perhaps changing the TaskExecutionException thrown in
nl.javadude.gradle.plugins.license.License back to a GradleException would
fix it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-32434630
.

from license-gradle-plugin.

Released 0.7.0, should contain #15 and this one.

from license-gradle-plugin.

Verified, it works. Thanks a lot!

from license-gradle-plugin.