Git Product home page Git Product logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 26, 2024
What I found out so far:

1. FUSE does indeed sometimes read data it has read before once more. These are 
usually ironed out by caching, but if the cache is full, problems like 
described 
above could occur. (Although I have not yet managed to run into one.)
2. The conditions for complete decompression on read cannot actually be met if 
cache_skipped is enabled. The condition (!cache_this_read || decomp_cache_size 
> 
max_decomp_cache_size) can never be true because we make sure to only cache 
data if 
decomp_cache_size < max_decomp_cache_size, so -- assuming that everything is 
page-
aligned -- the worst we can get is decomp_cache_size == max_decomp_cache_size.

I guess the solution is to fix 2. and fall back in the cache full case. It is 
IMO 
questionable, however, whether it makes sense to wait until the cache is full 
before 
doing so.

Original comment by [email protected] on 5 Sep 2008 at 12:39

from fusecompress.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 26, 2024
Another thing badly wrong with the aforementioned condition is that it may 
allow 
reads to files in direct-write mode without decompression if caching is enabled.

Original comment by [email protected] on 5 Sep 2008 at 12:52

from fusecompress.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 26, 2024
Fixed in r69:
a) The condition in question is now decomp_cache_size >= max_decomp_cache_size.
b) If it is possible to tell that the skip will not fit in the cache, we fall 
back 
instead. If we cannot fall back, we abstain from filling up the cache with data 
we 
most likely won't need for anything.
c) Skipping file->size bytes is enough to trigger a fallback now (3 * 
file->size 
before), but only data that is not cached counts towards it.

The Thing From Comment #2(tm) has also been fixed (see issue #26).

Original comment by [email protected] on 5 Sep 2008 at 3:19

  • Changed state: Fixed

from fusecompress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.