Git Product home page Git Product logo

Comments (7)

Hexilee avatar Hexilee commented on May 18, 2024

It may be useful but currently I do not have the use case and time. Maybe you can set a "flag" as default value?

from unhtml.rs.

jhpratt avatar jhpratt commented on May 18, 2024

@Hexilee That's certainly a possibility. Would you accept a PR if I created one? I'd certainly take a look at the code if you would!

from unhtml.rs.

Hexilee avatar Hexilee commented on May 18, 2024

PR is welcome! I will take some time to review the code and make the decision.

from unhtml.rs.

jhpratt avatar jhpratt commented on May 18, 2024

@Hexilee Looking through things now; it appears as though the only two errors that can be returned are SourceNotFound and SourceEmpty. If this is correct, would you agree that the appropriate thing to do is to cast both of them to an Option?

If that's the correct course of action, I actually think this should be as simple as calling .ok() on the result, as we're disregarding both possible errors.

from unhtml.rs.

Hexilee avatar Hexilee commented on May 18, 2024

The purpose to use Result instead of Option is debugging more conveniently. Maybe you can use Option and log the err.

from unhtml.rs.

Hexilee avatar Hexilee commented on May 18, 2024

@jhpratt Option<T> is supported in v0.7, documentation will be updated in few days, you can refer to the test compound.rs now.

from unhtml.rs.

Hexilee avatar Hexilee commented on May 18, 2024

I will close this issue

from unhtml.rs.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.