Git Product home page Git Product logo

Comments (6)

vladgurovich avatar vladgurovich commented on September 2, 2024

I have a suspicion that this gem may need to be redone from the ground up to support a more flexible search model provided by people/search
The whole idea of field selectors doesn't fit into predefined set of profile attributes provided with this gem.
This is just an educated guess on my part

from linkedin.

joshk avatar joshk commented on September 2, 2024

Hi ckarbass and vladgurovich,

I am currently updating the gem to work correctly with the xml apis, this includes updating search which is out of date (pull requests are more than welcome as well).

Regarding redoing the gem from the ground up, this is currently going on in another branch (json api, hashie, multi_json, and maybe oauth2), but this will take a little longer than initially planned.

As for the field selectors, this is ingrained in the LinkedIn api, so there is not much I can do about it, but if you have some suggestions I am all ears.

I will leave this issue open until the search api is working as per the updated api.

Thanks,

Josh

from linkedin.

vladgurovich avatar vladgurovich commented on September 2, 2024

A simpler but slightly less readable approach would be to abandon individual objects such as languages, country, etc etc in favor of something like Hashie(or specifically Mash).
The problem of course is that due to dynamic nature of field selectors, the structure of returned data is not as strict as one provided by your current implementation and will probably require the end users of your gem to have some knowledge of linked in responses.
Oh, I just noticed the mashie branch :)

from linkedin.

joshk avatar joshk commented on September 2, 2024

Hey vladgurovich,

Once V0.2.0 of the gem is released all my efforts will be focused on the new Hashie (Mash) Json branch, 90% less code with 50% more functionality*.

Watch this space

Josh

*numbers are not quantifiable, but you get the picture :)

from linkedin.

oscardelben avatar oscardelben commented on September 2, 2024

Hi, there is a new a pull request for the new search api

from linkedin.

hexgnu avatar hexgnu commented on September 2, 2024

Works for me, feel free to reopen this.

from linkedin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.