Git Product home page Git Product logo

Comments (2)

fabiokung avatar fabiokung commented on June 1, 2024

I mean:

func my() error {
    if err = doSomething(); err != nil {
        return err
    }
    // ...
}

Instead of:

func my() {
    if err = doSomething(); err != nil {
        log.Fatalf("....", err) // fmt.Fatal*, os.Exit, etc
    }
}

I'm personally not much a fan of *.Fatal* or other things that rely on os.Exit(). It doesn't allow other parts of the code to do proper cleanup (skips deferred functions) and/or recover from errors or do error handling. IMO even panic() would've been better. *.Fatal* is a last resort type of thing.

But that's just (my own?) code style. It's your call, don't sweat it too much.

from log-shuttle.

freeformz avatar freeformz commented on June 1, 2024

For a library, I'm in total agreement with you.

And as I said elsewhere the only places log.Fatal get's used in to abort and exit as fast as possible during setup tasks.

Thanks for the thought our response though.

from log-shuttle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.