Better Implementation Suggestion about heroku.rb HOT 14 CLOSED

I assert that it looks nothing like heroku.py :)

from heroku.rb.

Whoops, there is already heroku.py Didn't know it :) And even it looks better than heroku.rb.

Ok, what I mean is that current heroku.rb implementation looks nothing like it's for Ruby.

from heroku.rb.

🍰

from heroku.rb.

@goshakkk - I felt that the best starting point was a very direct implementation and that this would provide a good base point that could support many different abstractions (including one like this, but also future version of the CLI, etc). I just haven't had the time to come back and add such an implementation just yet. Thanks for the feedback though, I hope to get a chance to flesh this out more moving forward.

from heroku.rb.

Have got some spare time today and made my first attempt to implement my idea on top of current heroku.rb. https://github.com/goshakkk/ruroku

Would love to hear your thoughts.

from heroku.rb.

Pull requests are also welcome :P

from heroku.rb.

@goshakkk - looks cool, thanks for sharing your work with us!

from heroku.rb.

@goshakkk - P.S. if you email or message me your address and size I'd be happy to send you a tshirt to thank you doing cool open source Heroku stuff.

from heroku.rb.

@geemus nice to hear it! I'm a bit out of ideas for it, can you offer something else to implement? Pull requests are still welcome too :) P.S. Sending you the email right now.

from heroku.rb.

@goshakkk - good question, nothing is really jumping out at me as being missing though. I'll let you know if anything comes to mind.

from heroku.rb.

@geemus btw, as of heroku.rb implementation: I think get_logs should return actual logs, not url which I can fetch logs from. There could be get_logs_url for that. What do you think?

from heroku.rb.

@goshakkk - I certainly understand the confusion of that, but I think get_logs as it stands best reflects the current state of things. It makes a request to the api, at 'GET /apps/app/logs', which returns a completely separate location where the logs can be fetched with. I think something that could stream the logs would be useful, but I would argue it would make more sense to have that as a separate method and maybe even on a separate model. Overall I'd like to keep the implementation here as close to the api as possible to ease maintenance. A possible implementation of the log streamer might end up with usage like this:

log = Heroku::Log.new(url)
log.read

# or perhaps just:

Heroku::Log.read(url)

from heroku.rb.

@geemus thanks for the suggestion.

Also, did you receive my email yet?

from heroku.rb.

@goshakkk - yep, thanks, just saw it, haven't had a chance to respond just yet.

from heroku.rb.