Why Heroku::API.post_login is not a class method? about heroku.rb HOT 6 CLOSED

It was intended for cases where you wanted to use the username and password to get the apikey, but that was all you wanted to do (this is what the CLI does). I hadn't really considered wanting to continue using the api key afterward. I don't think just adding a class method is quite the right thing, but I think it should definitely be cleaner than this. How about if we update it so that you can do: instance = Heroku::API.new(:username => 'MYACCOUNT', :password => 'MYPASSWORD'). Then it can see that since you did not also supply an API_KEY, it will need to do a post_login on your behalf to find this value. I think this would preserve the consistent interface I want but also deal with the difficulties you mention here. Thoughts?

from heroku.rb.

instance = Heroku::API.new(:username => 'MYACCOUNT', :password => 'MYPASSWORD')

I think good!

from heroku.rb.

Oh, I'm late. please ignore a commit log of my fork...

from heroku.rb.

@AmaiSaeta - no problem, I'd been meaning to help out and finish this for a while but just got to it today.

from heroku.rb.

Thank you @geemus .

from heroku.rb.

@AmaiSaeta - sure thing, I'll work on getting a release out in the next day or two so this will be usable.

from heroku.rb.