Git Product home page Git Product logo

Comments (10)

schneems avatar schneems commented on July 25, 2024

Can you open up a support ticket for this? Or give us the ticket number of an existing support request?

Richard Schneeman
http://heroku.com
@schneems

Sent from the road

On Sunday, April 28, 2013 at 10:44 PM, John Hinnegan wrote:

Notice the first line? This was compiled on heroku.
I then precompiled the assets and pushed which fixed it. I should be able to just push and have it precompile on the heroku side though, no?
Thoughts? app is here https://github.com/softwaregravy/aws_info
some discussion already here: jruby/heroku-buildpack-jruby#10 (jruby/heroku-buildpack-jruby#10 (comment))


Reply to this email directly or view it on GitHub (#90).

from heroku-buildpack-ruby.

softwaregravy avatar softwaregravy commented on July 25, 2024

https://help.heroku.com/tickets/83883

from heroku-buildpack-ruby.

schneems avatar schneems commented on July 25, 2024

Hey, sorry for the delay. I tried reproducing this issue with a simple app: https://github.com/sharpstone/rails3_jruby_193

And then adding tests for it in the buildpack: https://travis-ci.org/heroku/heroku-buildpack-ruby/builds/7493621 but i'm not able to reproduce the issue. Am I missing something here?

from heroku-buildpack-ruby.

softwaregravy avatar softwaregravy commented on July 25, 2024

When I pushed my app referenced in the ticket and relied on heroku to precompile the assets, I got the error. I'll verify the repro step this afternoon. Your test app doesn't actually have any javascript in it to precompile, so that might be why you're not seeing it.

from heroku-buildpack-ruby.

schneems avatar schneems commented on July 25, 2024

Instead of getting my version to fail (which I tried further with no success) I tried to get yours to pass, which I was able to do after removing some libraries this was the resulting Gemfile: https://gist.github.com/schneems/5650672

I also had to remove this setting:

  config.assets.js_compressor = :closure

My guess is that the compiler is mistakenly taking results of standard out and inputting them to your file. I'm not familiar with that library and the pros/cons of using it.

from heroku-buildpack-ruby.

softwaregravy avatar softwaregravy commented on July 25, 2024

Did that deploy and run successfully?

With the gem file as you referenced, my app isn't starting up.

2013-05-26T00:10:05.678178+00:00 app[web.1]: /app/vendor/bundle/jruby/1.9/gems/jruby-openssl-0.8.7/lib/shared/jruby-openssl.rb:16 warning: already initialized constant OPENSSL_VERSION
2013-05-26T00:10:05.778267+00:00 app[web.1]: [WARNING] Please install gem 'therubyrhino' to use Less under JRuby.
2013-05-26T00:10:05.779869+00:00 app[web.1]:                   require at org/jruby/RubyKernel.java:1027
2013-05-26T00:10:05.779869+00:00 app[web.1]: LoadError: no such file to load -- rhino
2013-05-26T00:10:05.779869+00:00 app[web.1]:                    (root) at /app/vendor/bundle/jruby/1.9/gems/less-2.3.2/lib/less/java_script/rhino_context.rb:2
2013-05-26T00:10:05.779869+00:00 app[web.1]:                   require at org/jruby/RubyKernel.java:1027
2013-05-26T00:10:05.779869+00:00 app[web.1]:                    (root) at /app/vendor/bundle/jruby/1.9/gems/less-2.3.2/lib/less/java_script.rb:1
2013-05-26T00:10:05.779869+00:00 app[web.1]:           context_wrapper at /app/vendor/bundle/jruby/1.9/gems/less-2.3.2/lib/less/java_script.rb:17

If I add back therubyrhino, I get

2013-05-25T23:59:11.819124+00:00 app[web.1]: ActionController::RoutingError (No route matches [GET] "/assets/application-837b4171d8f17a73e2fc68dabff8ef5b.js"):
2013-05-25T23:59:11.819124+00:00 app[web.1]:   vendor/bundle/jruby/1.9/gems/actionpack-3.2.13/lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call'
2013-05-25T23:59:11.819124+00:00 app[web.1]:   vendor/bundle/jruby/1.9/gems/actionpack-3.2.13/lib/action_dispatch/middleware/show_exceptions.rb:56:in `call'

from heroku-buildpack-ruby.

softwaregravy avatar softwaregravy commented on July 25, 2024

Was doing my experiments on branch test_no_closure

from heroku-buildpack-ruby.

softwaregravy avatar softwaregravy commented on July 25, 2024

And, I think this is a caching error on my part

from heroku-buildpack-ruby.

hone avatar hone commented on July 25, 2024

@softwaregravy does that mean you managed to fix it?

from heroku-buildpack-ruby.

softwaregravy avatar softwaregravy commented on July 25, 2024

@hone Sorry, that comment was about the application.js not being found which I saw

this is still an issue. I've left the broken deployment out there for now, you can see it at https://aws-data.herokuapp.com/

Look at the top of the application.js file for the problem

Currently deployed code is on master branch at https://github.com/softwaregravy/aws_info

from heroku-buildpack-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.