Git Product home page Git Product logo

Comments (15)

hone avatar hone commented on August 28, 2024

I've never been a big fan of the way the rake task detection works. Is there a better way than using --dry-run?

from heroku-buildpack-ruby.

hone avatar hone commented on August 28, 2024

This is related to #9.

from heroku-buildpack-ruby.

wuputah avatar wuputah commented on August 28, 2024

A better way? No.
A different way? Yes.
https://gist.github.com/2922172

from heroku-buildpack-ruby.

wuputah avatar wuputah commented on August 28, 2024

Proposal:

  • Using something akin to the gist provided, provide better error messaging about why the pipeline failed.
  • Run pipeline in a limited environment and with --trace if DEBUG_PIPELINE=1

While a completely separate issue, follow Python's lead and allow users to turn off the pipeline entirely via DISABLE_PIPELINE=1

from heroku-buildpack-ruby.

hone avatar hone commented on August 28, 2024

@wuputah how does python do this?

from heroku-buildpack-ruby.

wuputah avatar wuputah commented on August 28, 2024

:s/ @wuputah / @kennethreitz /

from heroku-buildpack-ruby.

kennethreitz avatar kennethreitz commented on August 28, 2024

I allow users to disable it with DISABLE_COLLECTSTATIC=1, but ideally someone should almost never need to do that.

from heroku-buildpack-ruby.

wuputah avatar wuputah commented on August 28, 2024

@kennethreitz what happens if collectstatic fails (and, of course, is not disabled)?

from heroku-buildpack-ruby.

kennethreitz avatar kennethreitz commented on August 28, 2024

I do a dry run first. If it fails, nothing happens, the user doesn't see anything about.

If the dry run passes, I run it, if it fails, i tell them the output, and point to documentation on how to debug w/ heroku run.

from heroku-buildpack-ruby.

wuputah avatar wuputah commented on August 28, 2024

In the latter case, does the build still succeed?

from heroku-buildpack-ruby.

kennethreitz avatar kennethreitz commented on August 28, 2024

Yes. I had it fail at first, but too many people have configuration issues for that to be practical.

People have crazy configurations.

from heroku-buildpack-ruby.

kennethreitz avatar kennethreitz commented on August 28, 2024

In the long term future, I'd like to remove this feature completely and replace it with "add this oneliner to a build hook (e.g. bin/post_compile)" instead.

But, some things have to happen for that to be a reality.

from heroku-buildpack-ruby.

wuputah avatar wuputah commented on August 28, 2024

Okay, to come back to what I was talking about earlier, I was principally referring to Kenneth's use of DISABLE_COLLECTSTATIC.

from heroku-buildpack-ruby.

hone avatar hone commented on August 28, 2024

@wuputah i don't think we should be pushing build stuff through config vars.

from heroku-buildpack-ruby.

hone avatar hone commented on August 28, 2024

Should be solved by #34

from heroku-buildpack-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.