Comments (15)
I've never been a big fan of the way the rake task detection works. Is there a better way than using --dry-run
?
from heroku-buildpack-ruby.
This is related to #9.
from heroku-buildpack-ruby.
A better way? No.
A different way? Yes.
https://gist.github.com/2922172
from heroku-buildpack-ruby.
Proposal:
- Using something akin to the gist provided, provide better error messaging about why the pipeline failed.
- Run pipeline in a limited environment and with
--trace
ifDEBUG_PIPELINE=1
While a completely separate issue, follow Python's lead and allow users to turn off the pipeline entirely via DISABLE_PIPELINE=1
from heroku-buildpack-ruby.
@wuputah how does python do this?
from heroku-buildpack-ruby.
:s/ @wuputah / @kennethreitz /
from heroku-buildpack-ruby.
I allow users to disable it with DISABLE_COLLECTSTATIC=1
, but ideally someone should almost never need to do that.
from heroku-buildpack-ruby.
@kennethreitz what happens if collectstatic fails (and, of course, is not disabled)?
from heroku-buildpack-ruby.
I do a dry run first. If it fails, nothing happens, the user doesn't see anything about.
If the dry run passes, I run it, if it fails, i tell them the output, and point to documentation on how to debug w/ heroku run
.
from heroku-buildpack-ruby.
In the latter case, does the build still succeed?
from heroku-buildpack-ruby.
Yes. I had it fail at first, but too many people have configuration issues for that to be practical.
People have crazy configurations.
from heroku-buildpack-ruby.
In the long term future, I'd like to remove this feature completely and replace it with "add this oneliner to a build hook (e.g. bin/post_compile
)" instead.
But, some things have to happen for that to be a reality.
from heroku-buildpack-ruby.
Okay, to come back to what I was talking about earlier, I was principally referring to Kenneth's use of DISABLE_COLLECTSTATIC
.
from heroku-buildpack-ruby.
@wuputah i don't think we should be pushing build stuff through config vars.
from heroku-buildpack-ruby.
Should be solved by #34
from heroku-buildpack-ruby.
Related Issues (20)
- JRuby 9.4.2.0 support? HOT 4
- Upgrade to Node 18 LTS HOT 1
- Using ruby 3.3.0 for preview release (as suggested in the notes) raises error with bundler HOT 2
- JRuby 9.4.4.0 support? HOT 1
- Support Bundler 2.4.20+ to enable `ruby file: '.ruby-version'` in Gemfile HOT 9
- Support Ruby 3.2.3 HOT 1
- Bundler 2.5.6 Causes Builds to Fail HOT 10
- Possible Bundler 2.5.6 Issues HOT 5
- ruby required for compiling webpack assets in rails build, missing from nodejs buildpack and stack 22 HOT 1
- Failed to install gems via Bundler (2.5.6) on Ruby 2.7.8 HOT 1
- Rails builds fail if `BUNDLE_WITHOUT="'development:test'"` (note the extra quotes)
- Support ARM64 when using Heroku-24 Docker images HOT 3
- Support Ruby 3.1.6 and 3.3.2 HOT 3
- Upstream bundler change removes credentials from Gemfile.lock, breaking Heroku build process HOT 1
- Support Ruby 3.3.3 HOT 1
- Remove unused logging code
- Windows gemfile breaks deployment HOT 2
- Error deploying Ruby app on heroku-24 HOT 6
- cp: non-portable warning
- Feature Request: Support for Jemalloc w/o Separate Build Pack
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroku-buildpack-ruby.