Git Product home page Git Product logo

Comments (4)

hone avatar hone commented on August 28, 2024

@mmcgrana how would you suggest detecting it? We don't have the DATABASE_URL env var at build time to even check that exists. The only other option is to look at the gems. Obviously there is pg, mysql, mysql2, but do we need now to maintain a whitelist of known good db drivers?

from heroku-buildpack-ruby.

hone avatar hone commented on August 28, 2024

Going to close due to inactivity. Please reopen when you want to take a look again.

from heroku-buildpack-ruby.

mmcgrana avatar mmcgrana commented on August 28, 2024

@hone I thought that at some point we only added the database for "Ruby/Rails" apps, but not for "Ruby/Rack" and just "Ruby" apps. I was just thinking of using the app type to detect. If that either isn't possible or wouldn't make sense then np, just wanted to throw the idea out.

from heroku-buildpack-ruby.

hone avatar hone commented on August 28, 2024

@mmcgrana nope, we're giving out to everyone it seems. We only special case adding the postgres addon.

from heroku-buildpack-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.