Git Product home page Git Product logo

Comments (8)

Hermanya avatar Hermanya commented on September 2, 2024 3

it might :)

from create-react-hook.

Hermanya avatar Hermanya commented on September 2, 2024 2

I agree it would be nice if created projects had that setting by default. What I'm saying is I don't know how to make it work. If I add that setting into templates here, then I won't be able to publish create-react-hook on npm, because it's not going to include all files. I'm sure there is a way around that, but I don't know what it is.

from create-react-hook.

Hermanya avatar Hermanya commented on September 2, 2024 1

The problem is that other files in that directory will be ignored when I publish create-react-hook. Nesting package.jsons is problematic. But there must be a way to do it

from create-react-hook.

elzup avatar elzup commented on September 2, 2024 1

ok. It's a Proposal. My project has no problem.
packages.json does not include "files" property by create-react-app project-name --typescript`
Wouldn't it be nice for TypeScript library developers in most cases?

The problem is that other files in that directory will be ignored when I publish create-react-hook.
Does it affect "gh-pages" sample project deploy? It is better to deploy the module.

from create-react-hook.

fulviocanducci avatar fulviocanducci commented on September 2, 2024

I resolved it as follows:

@Hermanya and @elzup

"files": [
    "dist/"
],

in the file package.json

from create-react-hook.

fulviocanducci avatar fulviocanducci commented on September 2, 2024

I agree it would be nice if created projects had that setting by default. What I'm saying is I don't know how to make it work. If I add that setting into templates here, then I won't be able to publish create-react-hook on npm, because it's not going to include all files. I'm sure there is a way around that, but I don't know what it is.

How is the create-react-hook package.json file created for the Typescript template?

from create-react-hook.

Hermanya avatar Hermanya commented on September 2, 2024

It's copied from https://github.com/Hermanya/create-react-hook/blob/master/template/typescript/package.json

from create-react-hook.

fulviocanducci avatar fulviocanducci commented on September 2, 2024

It's copied from https://github.com/Hermanya/create-react-hook/blob/master/template/typescript/package.json

Wouldn't a variable like that in {{name}} solve automatically?

from create-react-hook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.