Git Product home page Git Product logo

Comments (4)

igalic avatar igalic commented on August 26, 2024

augeas/src/fa.c

Line 125 in 4f3bbeb

bs[bit/UINT_BIT] |= 1 << (bit % UINT_BIT);

i reckon instead of 1 we should have used 1u in these functions

from augeas.

228938596 avatar 228938596 commented on August 26, 2024

augeas/src/fa.c

Line 125 in 4f3bbeb

bs[bit/UINT_BIT] |= 1 << (bit % UINT_BIT);

我认为1我们应该1u在这些功能中使用而不是

Following your suggestion, indeed this error can be resolved, thanks
125 bs[bit/UINT_BIT] |= 1u << (bit % UINT_BIT);

from augeas.

igalic avatar igalic commented on August 26, 2024

what about

augeas/src/fa.c

Line 121 in 4f3bbeb

bs[bit/UINT_BIT] &= ~(1 << (bit % UINT_BIT));
? does it also need to be changed to:

 bs[bit/UINT_BIT] &= ~(1u << (bit % UINT_BIT)); 

or does that break something?

When you find out, can you please submit a pull request?

from augeas.

228938596 avatar 228938596 commented on August 26, 2024

关于什么

augeas/src/fa.c

Line 121 in 4f3bbeb

bs[bit/UINT_BIT] &= ~(1 << (bit % UINT_BIT));

?是不是也需要改成:

 bs[bit/UINT_BIT] &= ~(1u << (bit % UINT_BIT)); 

还是那会破坏某些东西?

当你发现时,你能提出一个拉取请求吗?

Yes, line 121 needs to be modified

from augeas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.