Shouldn't be difficult, if you want to do a pull request I'd be happy to merge it in. Or give me a couple days and I'll come up with something. thanks

from handlebars-helpers.

I don't use coffeescript - if my pull script updates the lib/helpers/helpers-collection.js and the unit test, would that be ok?

from handlebars-helpers.

Absolutely. I'm easy going, any contribution is cool with me, I'd be happy to convert to coffee for you (we might get rid of it anyway, I'm not a big fan of having to code the helpers in coffee)

from handlebars-helpers.

Pull request sent. Comments in there for the details and if you don't want it as I did it, I understand. Thank you for this project - I love Handlebars and these libraries are awesome.

from handlebars-helpers.

👍 thanks for the pull request! I'll get it pulled in sometime today.

from handlebars-helpers.

btw, you might be interested in the experimental helpers I maintain here: https://github.com/assemble/handlebars-helpers-examples/tree/master/experimental/helpers

Some of them aren't even finished... but I keep them pushed up just in case they help inspire other ideas.

from handlebars-helpers.

Btw - I figured out to use grunt to run the tests locally and I've gotten a coffeescript version of eachIndexPlusOne along with the test done too. It is "more" proper, so I won't be offended if you nuke my pull request. I can definitely make a new one.

from handlebars-helpers.

did you make the coffee changes to the same clone? if so you can just push it up again and it will add to this request automatically. Or we can nuke this and you can just do a new request if that's not too much trouble. Either way, let me know what works for you. thanks!

from handlebars-helpers.

btw, do you have any clue as to why there was so much activity on this repo today? don't get me wrong it's pretty awesome for sure lol, but we got a lot of stars today and I'm just curious as to why

from handlebars-helpers.

I'll be honest - I'm a Git neophyte. I use the hell out of it for my
projects, but cloning/pull requests still confuse me. I'm worried a new
push of the same stuff would keep both my mods in and obviously the JS mods
need to go away since the Grunt task overwrites em. I'll do whatever makes
it easier to get it in though (hell, even emailing the two files ;)

On Fri, Aug 2, 2013 at 4:42 PM, Jon Schlinkert [email protected]:

did you make the coffee changes to the same clone? if so you can just push
it up again and it will add to this request automatically. Or we can nuke
this and you can just do a new request if that's not too much trouble.
Either way, let me know what works for you. thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/43#issuecomment-22037811
.

Raymond Camden, Adobe Developer Evangelist

Email : [email protected]
Blog : www.raymondcamden.com
Twitter: cfjedimaster

from handlebars-helpers.

I tweeted it. I've got mildly high visibility (5.9k followers), but I'm no
super star.

On Fri, Aug 2, 2013 at 4:43 PM, Jon Schlinkert [email protected]:

btw, do you have any clue as to why there was so much activity on this
repo today? don't get me wrong it's pretty awesome for sure lol, but we got
a lot of stars today and I'm just curious as to why

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/43#issuecomment-22037885
.

Raymond Camden, Adobe Developer Evangelist

Email : [email protected]
Blog : www.raymondcamden.com
Twitter: cfjedimaster

from handlebars-helpers.

well that might be why lol. 5.9k is nothing to sneeze at. thanks a lot!

from handlebars-helpers.

I'm worried a new push...

Well, if it's all the same to you, I'd hate to pass up this chance for you to see what happens when you do it lol. Since your code won't do anything to effect this repo unless the pull request is merged in, why don't you just push it up to see what happens. And then we can delete/close this and you can do a new one from scratch if it's messed up. It's impossible to offend the Git Gods more than I have... I promise you lol.

from handlebars-helpers.

Ok - here goes nothing then...

On Fri, Aug 2, 2013 at 4:51 PM, Jon Schlinkert [email protected]:

I'm worried a new push...

Well, if it's all the same to you, I'd hate to pass up this chance for you
to see what happens when you do it lol. Since your code won't do anything
to effect this repo unless the pull request is merged in, why don't you
just push it up to see what happens. And then we can delete/close this and
you can do a new one from scratch if it's messed up. It's impossible to
offend the Git Gods more than I have... I promise you lol.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/43#issuecomment-22038342
.

Raymond Camden, Adobe Developer Evangelist

Email : [email protected]
Blog : www.raymondcamden.com
Twitter: cfjedimaster

from handlebars-helpers.

Ok, the Pull Request contains both commits. My first commit is definitely bad. I missed the module export in the JS. Of course, it will also be blown away when you run grunt build. So my opinion is this. Accept the pull request (again, assuming you are cool with the name), run a grunt build locally, not that the collection JS file will be overwritten - and then commit that yourself to make it 'cleaner' (imo) since people (like me) will skip the coffeescript versions probably and just use the JS. Hope that makes sense. I need beer now.

from handlebars-helpers.

sounds great, the code looks great, and I'll do what you suggested.

I need beer now.
ha, have a good one

thanks!

from handlebars-helpers.

Does eachIndex+1 was implemented?

from handlebars-helpers.