Git Product home page Git Product logo

Comments (4)

prydonius avatar prydonius commented on July 4, 2024 1

Thanks for writing this up, Scott! One issue with this is that the Monocular currently gets the name and URL of the repo from the arguments passed to chart-repo: https://github.com/helm/monocular/blob/master/cmd/chart-repo/sync.go#L28. Whilst we could add the colour as a third argument, it might be a bit strange to have that as an argument in the chart-repo command. We could instead have a way of passing arbitrary additional metadata to be included in the repo struct it stores in MongoDB.

This could cause a turf war over company "owned" colors, and maybe confuse seeing one company's green as more ready to go than another company's red color ¯(ツ)/¯.

This point does concern me a bit, it would be simpler to show all repos with the same colour (removing the current distinction between stable/incubator and non-stable/incubator) and avoid this entirely.

from hub.

scottrigby avatar scottrigby commented on July 4, 2024 1

Ah I see the grey is only on the earlier kubeapps implementation. Yes I agree, this seems important to keep. OK closing this, glad we have the discussion for reference in case we ever want to revisit or reference 👍

from hub.

scottrigby avatar scottrigby commented on July 4, 2024

@prydonius I agree 💯

it would be simpler to show all repos with the same colour (removing the current distinction between stable/incubator and non-stable/incubator) and avoid this entirely

I suppose we should keep this issue open till that's done, or until someone offers a better idea 🙂

from hub.

prydonius avatar prydonius commented on July 4, 2024

So actually Monocular only makes a distinction between the incubator repo and other repos (marking it red instead of blue). This can be seen here: https://hub.helm.sh/. Kubeapps Hub is a little different here in that in distinguishes between stable, incubator and other repos.

I kind of like that the incubator repository is marked red, it might help point out that it is not recommended to be used?

from hub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.