Git Product home page Git Product logo

Comments (6)

madninja avatar madninja commented on June 12, 2024

use angry_purple_tiger::AnimalName;

let address = "112CuoXo7WCcp6GGwDNBo6H5nKXGH45UNJ39iEefdv2mwmnwdFt8"; let animal_name = known.parse::().expect("animal name"); assert_eq!(animal_name, "feisty-glass-dalmatian")

you're asking if it should be

let animal_name = known.parse::().expect("animal name");

instead of

let animal_name = address.parse::().expect("animal name");

If so that seems like a personal preference?

from angry-purple-tiger-rs.

masstensor avatar masstensor commented on June 12, 2024

yeah, I think "known" is a typo, it should be replace with "address".

from angry-purple-tiger-rs.

madninja avatar madninja commented on June 12, 2024

sure.. want to submit a PR?

from angry-purple-tiger-rs.

masstensor avatar masstensor commented on June 12, 2024

It seems that I have no permission to submit a PR...

from angry-purple-tiger-rs.

madninja avatar madninja commented on June 12, 2024

You fork the repo and do a PR from your fork

from angry-purple-tiger-rs.

masstensor avatar masstensor commented on June 12, 2024

OK, i have create a pull request, please review it, thanks.

from angry-purple-tiger-rs.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.