Git Product home page Git Product logo

Comments (3)

barchetta avatar barchetta commented on May 22, 2024

I've reproduced this. The webserver immediately closes the connect upon hitting the exception which results in an empty response to the client. This is clearly a bug. On an error the server should be returning the correct HTTP status (maybe 400 in this case? See next point).

The next question is if the URL is valid as represented in the HTTP request sent to the server. It appears as though curl is not encoding the URL. The webserver is assuming that incoming URLs are correctly encoded (as defined by the HTTP protocol). In this case the URL in the HTTP request is not URL encoded (It is not http://localhost:8080/greet/%E5%B0%8F%E9%AB%98). And therefore the webserver gets the exception.

If you try the same thing but use a browser to enter the URL it should work, because the browser encodes the URL. It worked for me with both Chrome and Firefox.

But we do need to fix the error handling in the webserver so that it handles the exception and returns an HTTP status code.

from helidon.

romain-grecourt avatar romain-grecourt commented on May 22, 2024

@barchetta I've targeted this to 1.0

from helidon.

barchetta avatar barchetta commented on May 22, 2024

This is fixed by PR #796

from helidon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.