Why iterate process when calling heim_process::get about heim HOT 2 OPEN

Hey, @roblabla!

It was done to provide better guarantees for pid_exists function. Since current implementation is pretty much a copy of psutil (Python one) library, you can find more details on it here: giampaolo/psutil#1094

from heim.

PSUtil doesn't call pid_exists when getting a process by pid though. E.G. in psutil, the following:

process = Process(512)
cwd = process.cwd()

Will never call pid_exists as far as I can tell. pid_exists is only called in the wait function, and in the send_signal function, but only for OpenBSD.

In heim, this equivalent code will call pid_exists (and thus may call pids):

let process = heim_process::get(512);
let cwd = process.cwd()

This feels unnecessary. It doesn't actually improve reliability since the process may die between the get and the cwd functions, and cwd (and all other functions on Process) already handle the case where the process dies on us by returning an error.

When the user tries to get a Process, we shouldn't check if the pid exists (beyond raising an error if getting the create_time fails) IMO.

from heim.