Git Product home page Git Product logo

Comments (4)

urbnsr avatar urbnsr commented on June 28, 2024

This issue doesn't seem to attract much attention, so is there a way to run an older (working tags) version under the latest Ubuntu? Thanks...
Re:
http://code.google.com/p/heekscnc/issues/detail?id=316

from heekscnc-old.

alpharesearch avatar alpharesearch commented on June 28, 2024

This is still an issue today (Linux Mint 13)... I don't see why this works with windows and not with linux? looks like any other function??

from heekscnc-old.

alpharesearch avatar alpharesearch commented on June 28, 2024

Here is the fix I found for the tag issues, this works under Mint 13 64bit...

commit fbb6ee30a9b4cf53b704d1998cfe7f37a7a5d83f
Author: Markus Schulz
Date:   Thu Aug 30 17:25:04 2012 -0400

    tag fix for linux

diff --git a/src/Profile.cpp b/src/Profile.cpp
index 9f9d112..8f01e5c 100755
--- a/src/Profile.cpp
+++ b/src/Profile.cpp
@@ -1042,7 +1042,8 @@ public:
    {
        heeksCAD->CreateUndoPoint();
        CTag* new_object = new CTag();
-       object_for_tools->Tags()->Add(new_object, NULL);
+       CTags* temp = object_for_tools->Tags();
+       temp->Add(new_object, NULL);
        heeksCAD->Changed();
        heeksCAD->ClearMarkedList();
        heeksCAD->Mark(new_object);
diff --git a/src/Tag.cpp b/src/Tag.cpp
index 5b53f8a..abd6dd2 100644
--- a/src/Tag.cpp
+++ b/src/Tag.cpp
@@ -77,7 +77,7 @@ void CTag::GetProperties(std::list<Property *> *list)

 static CTag* object_for_tools = NULL;

-class PickPos: public Tool{
+class PickPos2: public Tool{
    // Tool's virtual functions
    const wxChar* GetTitle(){return _("Pick position");}
    void Run(){
@@ -88,12 +88,12 @@ class PickPos: public Tool{
    wxString BitmapPath(){ return _T("tagpos");}
 };

-static PickPos pick_pos;
+static PickPos2 pick_pos2;

 void CTag::GetTools(std::list<Tool*>* t_list, const wxPoint* p)
 {
    object_for_tools = this;
-   t_list->push_back(&pick_pos);
+   t_list->push_back(&pick_pos2);

 }

Looks like two issues caused the bug:

  1. in the debugger this was listed as a CProfile object but this needs to be a CTags object (Profile.cpp)
  2. looks like there is another PickPos class in heekscad it self and it was resolving the wrong path and went all the way to the pure virtual class (Tag.cpp)

from heekscnc-old.

sliptonic avatar sliptonic commented on June 28, 2024

Confirmed fix and pushed to master.

from heekscnc-old.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.