Git Product home page Git Product logo

Comments (8)

christian-heusel avatar christian-heusel commented on August 17, 2024

This especially breaks for me because ansibles community.docker.docker_compose module uses regular docker compose (?) apparently.

from container.

christian-heusel avatar christian-heusel commented on August 17, 2024

Problem is introduced in 217b903

from container.

christian-heusel avatar christian-heusel commented on August 17, 2024

Also --mount in 6893f0e causes this to fail

from container.

ErikMichelson avatar ErikMichelson commented on August 17, 2024

Yes, it's right that we rely on docker buildkit (buildx) now.
If you want to build the container from source for yourself, you'll need something similar to:

- name: Build image
  shell: |
    docker buildx build ...

Otherwise keep in mind, that we have pre-built images that regularly get rebuilded (to receive base image updates): https://quay.io/repository/hedgedoc/hedgedoc?tab=tags

from container.

christian-heusel avatar christian-heusel commented on August 17, 2024

Yes we do some small modifications to the hedgedoc sourcecode of only one could be upstreamed:
https://github.com/FachschaftMathPhysInfo/hedgedoc/tree/1.9.7_guest
https://github.com/FachschaftMathPhysInfo/hedgedoc/tree/1.9.7

But thank you for the input, I will have a look at your suggestion to use buildx directly.

from container.

ErikMichelson avatar ErikMichelson commented on August 17, 2024

Which of the modifications are you talking about? The guest user name or the login message?

For the login message, HedgeDoc 2 will provide a better UI where it will be possible to customize more content.

The guest user name thing sounds interesing and I absolutely see your use-case, however as HedgeDoc 1.x is in "maintenance only", we won't introduce such a config option. Anyway you could create an issue for that for HedgeDoc 2 if you're interested in that.

from container.

christian-heusel avatar christian-heusel commented on August 17, 2024

Which of the modifications are you talking about? The guest user name or the login message?

I just referenced our modifications because that hinders us from using the upstream docker image (which obviously would also solve the problem) 😄
Should have been more clear on that, sorry!

For the login message, HedgeDoc 2 will provide a better UI where it will be possible to customize more content.

Thats sounds great!

The guest user name thing sounds interesing and I absolutely see your use-case, however as HedgeDoc 1.x is in "maintenance only", we won't introduce such a config option. Anyway you could create an issue for that for HedgeDoc 2 if you're interested in that.

We host one HedgeDoc instance behind a Kerberos Login and Users Automatically get their name like that. 😊
The way it is done currently with the hacked guest note is not so nice, but it would be great if HedgeDoc 2 would have something like that targeted at a more general usecase. 😄

from container.

christian-heusel avatar christian-heusel commented on August 17, 2024

Thanks a lot for your help @ErikMichelson, I have now decided to with the solution you suggested! ❤️

- name: checkout the container repo
  ansible.builtin.git:
    repo: 'https://github.com/hedgedoc/container.git'
    dest: "/opt/docker/hedgedoc-container-build"

- name: build the containers
  ansible.builtin.shell: >
    docker buildx build
    --build-arg "VERSION={{ item.version }}"
    --build-arg "HEDGEDOC_REPOSITORY=https://github.com/FachschaftMathPhysInfo/hedgedoc.git"
    --file "/opt/docker/hedgedoc-container-build/debian/Dockerfile"
    --tag "local.image/fachschaftmathphysinfo/hedgedoc:{{ item.version }}"
    "/opt/docker/hedgedoc-container-build"
  with_items:
    - version: "1.9.7"
    - version: "1.9.7_guest"

from container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.