Git Product home page Git Product logo

Comments (7)

josevalim avatar josevalim commented on July 28, 2024

Patch with tests please. :)

from simple_form.

javierm avatar javierm commented on July 28, 2024

Mmm... didn't I attach it before?

Just kidding :-). Here you are. I hope this is the right format to do it: http://gist.github.com/498632

The source code is very readable; kudos for that. I don't know much about the whole builder thing, but still been able to do something that apparently doesn't break anything.

from simple_form.

josevalim avatar josevalim commented on July 28, 2024

The patch looks great! There is only you thing, you haven't used git format-patch, so I don't have you as commit author, neither the commit message. So I could apply this, but you wouldn't get any credit.

from simple_form.

javierm avatar javierm commented on July 28, 2024

Fine with me.

from simple_form.

javierv avatar javierv commented on July 28, 2024

I've created a new account where I can make these kind of contributions.

In case it helps, the patch is now in my repository:

http://github.com/javierv/simple_form/commit/db9c1b8eca11c2f3ba2a248f8cc53be6fe0f247c

from simple_form.

josevalim avatar josevalim commented on July 28, 2024

Ohhh, sweet. Thanks!

from simple_form.

carlosantoniodasilva avatar carlosantoniodasilva commented on July 28, 2024

Applied, thanks!

from simple_form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.