Comments (7)
Patch with tests please. :)
from simple_form.
Mmm... didn't I attach it before?
Just kidding :-). Here you are. I hope this is the right format to do it: http://gist.github.com/498632
The source code is very readable; kudos for that. I don't know much about the whole builder thing, but still been able to do something that apparently doesn't break anything.
from simple_form.
The patch looks great! There is only you thing, you haven't used git format-patch, so I don't have you as commit author, neither the commit message. So I could apply this, but you wouldn't get any credit.
from simple_form.
Fine with me.
from simple_form.
I've created a new account where I can make these kind of contributions.
In case it helps, the patch is now in my repository:
http://github.com/javierv/simple_form/commit/db9c1b8eca11c2f3ba2a248f8cc53be6fe0f247c
from simple_form.
Ohhh, sweet. Thanks!
from simple_form.
Applied, thanks!
from simple_form.
Related Issues (20)
- @builder.input_field(:license_plate, type: 'radio' .... ) output a textarea tag instead of an inpt HOT 1
- Broken Link in Readme File for Bootstrap Live App example HOT 4
- Chrome error: label's for attribute doesn't match any element id HOT 1
- Bootstrap floating labels keep floating even without input HOT 1
- Auto reload configuration HOT 4
- `config.default_form_class` should not be *overriden* but *complemented* when `html: { :class }` is specified HOT 1
- Redundant aria-required on required fields HOT 1
- 5.3.0 - Custom Inputs Fail to Load HOT 4
- Rails 7.1 updated password validation changed rendering of password inputs HOT 1
- Custom Component raise an error with rails 7.1 and zeitwerk HOT 1
- Hints don't work on the namespaced model HOT 2
- Encrypted attributes always default to textarea
- Proposal for customizable classes merging HOT 1
- The custom `error:` on all inputs does not work if there is an object present HOT 3
- Multiple inputs with the same name generate unparseable names in Rails >= 7.1.1 HOT 1
- <div class="checkbox"> <input value="false" type="hidden" name="meal[completed]"> <input class="boolean optional" type="checkbox" value="true" checked="checked" name="meal[completed]" id="meal_completed"> <label class="boolean optional" for="meal_completed">Completed</label> </div>Update: This bug only appears if you have custom value for `unchecked_value`. In this case `unchecked_value: false` HOT 1
- https://simple-form-bootstrap.herokuapp.com/ is Down HOT 2
- Label's for attribute doesn't match the id when nil is given in collection
- Adding a data-x attribute to the root <form>? HOT 1
- Disabled radio_buttons field doesn't post the correct value. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple_form.