Comments (3)
Hi,
Moreover, this function is unused: neither Hackage nor GHC refer to it.
Well there are plenty of projects not on Hackage though :)
The code itself is prone to be broken in future, because it relies on an internal API (there are actually ideas to back ByteString by ByteArray# instead of ForeignPtr).
Interesting, Wouldn't this represent a regression for code that read from an I/O source. Currently the I/O manager can feed bytestring efficiently from a native pointer that's maintained from the Buffers inside GHC. By forcing it to use a ByteArray#
that would require moving memory from the C side to Haskell would it not?
It would seem to me that bytestring would always require a way to create a binary representation from an unmanaged pointer...
That said I have no problem removing this function as it's functionality questionably shouldn't be in Win32 anyway which is meant to just be a low level interface to platform APIs. It would however in the grand scheme of things be very unfortunate not to be able to use bytestring...
from win32.
Interesting, Wouldn't this represent a regression for code that read from an I/O source.
Practically speaking, this particular change is not gonna happen any time soon. There is an ongoing discussion at haskell/bytestring#193, feel free to chime in. My point was more about relying on internal API in general.
That said I have no problem removing this function as it's functionality questionably shouldn't be in Win32 anyway which is meant to just be a low level interface to platform APIs.
Would you like me to raise a PR?
from win32.
Would you like me to raise a PR?
If you would that would be grand :) Thanks!
from win32.
Related Issues (20)
- Win32-2.6.2.1, provided by GHC 8.10.6 and 8.10.7, is not on Hackage HOT 2
- `isMinTTY` no longer detects recent `mintty`s HOT 7
- Change maxLength to 16 in function getComputerName HOT 1
- If `--io-manager=native`, `withHandleToHANDLE` does not work for a 'console' `Handle` HOT 7
- `Setup.hs` seems inconsistent with the `build-type` option of the cabal file. HOT 1
- Support for `schannel.h` and `wincrypt.h` functions HOT 1
- Add constant `INVALID_SET_FILE_POINTER`
- Provide `GetTempFileNameW`
- Expose `FindData` struct HOT 5
- createFile without busy-wait HOT 6
- fails to start soon after starlink terminal power on HOT 1
- Change type synonym used in `loadLibrary{Ex}`'s return type from `HINSTANCE` to `HMODULE`
- Is it possible to use this package to control the Microsoft Excel application? HOT 2
- `System.Win32.MinTTY` doesn't detect newer versions of `mintty` (but perhaps that's OK) HOT 5
- Add setWindowPos and getConsoleWindow HOT 1
- Support filepath >= 1.5.0.0 and os-string HOT 1
- #221 Introduced unused-imports warnings which lead to failures in GHC HOT 7
- Make hackage revision for 2.13.3.0 HOT 3
- Can't retrieve registry value size HOT 2
- Please build and upload documentation to Hackage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from win32.