Comments (13)
I will investigate tomorrow. Also, I will have 0.5.6.1, which in addition to this will fix some warnings I forgot and renames the Typeable.h
file, which sometimes aliases with the Typeable.h
from base
(and generates warnings).
BTW, I am seeing several 'redundant imports' warnings on GHC-head, for example for Applicative(..)
from Control.Applicative
. I imagine lot of code has to deal with this -- is there a simple way of quieting those warnings while keeping the rest? I could only come up with conditional compilation.
from containers.
I'm pretty sure conditional compilation is the only way. The hangs are a nasty surprise, but I don't know if I'll have a chance to investigate them tonight.
from containers.
On the same subject, the map/coerce
tests I added must only be run when optimization is enabled, and I forgot to even think about that. Also, I don't know how. However, that shouldn't lead to any <<<loop>>>
exceptions.
from containers.
Why are there tests that only work with optimizations enabled?
As for the imports, we should use conditional compilation.
from containers.
I have disabled the coercion tests for the time being. They depend on RULES being fired, that it why optimization is needed.
from containers.
@hvr I am seeing the problem, my stupid fault which manifests only on base 4.8. That is what I get for not using cabal when testing (as then it does not use MIN_VERSION_base). If you want some laugh, look at toList
definition in Foldable
class for base 4.8 :-)
I will commit today, after I will perform GHC validation.
from containers.
Once fixed can you please make a bugfix release?
from containers.
I was counting with that, now that I have the rights :-)
from containers.
fyi, I've just added a base < 4.8
constraint to containers-0.5.6.0
to mark that release uninstallable for base-4.8:
http://hackage.haskell.org/package/containers-0.5.6.0/revisions/
from containers.
Thanks, useful.
from containers.
@hvr I just released containers-0.5.6.1
. The containers testsuite works on ghc 7-{0,4,6,8,head} and I also validated current ghc-master (only package01e.stderr
must be updated to accomodate increased containers
version).
from containers.
Why are there tests that only work with optimizations enabled?
Because they are intended to test whether map/coerce RULES are working
properly.
from containers.
@foxik thanks; I updated GHC via ghc/ghc@5444560 yesterday (so today's PPA ghc-head build does already carry containers-0.5.6.1
)
from containers.
Related Issues (20)
- Symmetric difference for sets
- Incorrect order of Applicative actions in mergeA when using filterAMissing HOT 4
- `IntMap` `isProperSubmapOfBy` test failure HOT 4
- More accurate Set and Map size warnings HOT 3
- Complexity of IntMap-IntMap operations
- Is this repo up to date? HOT 7
- Consider maintaining the x.y.z.a versioning HOT 7
- Rewrite rules for IntMap: intersectionWithKey/mapWithKey HOT 8
- Faster Eq and Ord HOT 4
- Tidy up IntSet/IntMap bitwise stuff
- Improve strictness tests HOT 4
- Data.Map.Strict.mergeWithKey does not force the result of the combining function HOT 5
- Add "Unsafe" modules HOT 6
- Add `flattenSCC1 : SCC vertex -> Data.List.NonEmpty.NonEmpty vertex` HOT 2
- Data.Map.Internal does not export insertMin HOT 1
- Repo: remove merged branches?
- Contribution guide outdated?
- Potential memory optimization for IntMap and IntSet HOT 8
- Errors when trying to generate a test coverage report HOT 10
- Full IntSets? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from containers.