Comments (9)
mitchellh
commented on July 17, 2024
1
Let's keep this open and see if this issue is fixed when we use glint as our UI framework. Maybe its just the way we're sending ANSI escape codes. Still a bug in VS Code it seems though.
from waypoint.
evanphx
commented on July 17, 2024
There are some artifacts from the window being narrow above, but given we're doing pretty basic ANSI terminal things, this feels like a vscode bug. I think the best we could here is to have a flag to build to disable the internal scrolling output entirely to work around the vscode bug.
from waypoint.
thrashr888
commented on July 17, 2024
there's definitely a mem leak. vscode goes up to 4GB.
if i select "keep waiting" it continues to hang, then eventually crashes:
from waypoint.
thrashr888
commented on July 17, 2024
I added a note to the description that normal width output works fine and does not hang or crash.
from waypoint.
pearkes
commented on July 17, 2024
I’d be curious if this still happens when running latest given how “plain mode” detection now works and the UI framework has been replaced.
@thrashr888 do you mind trying again?
from waypoint.
thrashr888
commented on July 17, 2024
during up i noticed a new/different issue. it now re-writes the first line. i caught a gif:
from waypoint.
thrashr888
commented on July 17, 2024
No more crashing!
I do get a fun new error (as reported in #269):
Creating new buildpack-based image using builder: heroku/buildpacks:18Creating new buildpack-based image using builder: heroku/buildpacks:18Creating new buildpack-based image using builder: heroku/buildpacks:18Creating new buildpack-based image using builder: heroku/buildpacks:18Creating new buildpack-based image using builder: heroku/buildpacks:18Creating new buildpack-based image using builder: heroku/buildpacks:18Creating new buildpack-based image using builder: heroku/buildpacks:18✓ Creating pack client✓ Building image ｜ [exporter] Adding layer 'heroku/ruby:ruby'
｜ [exporter] Adding 1/1 app layer(s)
｜ [exporter] Reusing layer 'launcher'
｜ [exporter] Reusing layer 'config'
｜ [exporter] Adding label 'io.buildpacks.lifecycle.metadata'
｜ [exporter] Adding label 'io.buildpacks.build.metadata'
｜ [exporter] Adding label 'io.buildpacks.project.metadata'
｜ [exporter] *** Images (970b3d18dc22):
｜ [exporter] index.docker.io/library/example-ruby:latest
｜ [exporter] Adding cache layer 'heroku/ruby:gems'
✓ Injecting entrypoint binary to image
Generated new Docker image: example-ruby:latest
» Deploying...
✓ Setting up waypoint network
✓ Starting container
» Releasing...panic: runtime error: slice bounds out of range [:5] with length 4
goroutine 1 [running]:
github.com/mitchellh/go-glint.clampTextWidth(0xc00001e0f0, 0xe2, 0x4b, 0xe2, 0x0)
/go/pkg/mod/github.com/mitchellh/[email protected]/measure.go:179 +0x81f
github.com/mitchellh/go-glint.MeasureTextNode(0xc000c1b100, 0x42960000, 0x1, 0xc07fc00001, 0x0, 0x9)
/go/pkg/mod/github.com/mitchellh/[email protected]/measure.go:76 +0x199
github.com/mitchellh/go-glint/flex.nodeWithMeasureFuncSetMeasuredDimensions(0xc000c1b100, 0x7fc0000142960000, 0x1, 0x0, 0x7fc0000142960000)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1276 +0x1af
github.com/mitchellh/go-glint/flex.nodelayoutImpl(0xc000c1b100, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0xffffffffffffff00, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1488 +0x5a2d
github.com/mitchellh/go-glint/flex.layoutNodeInternal(0xc000c1b100, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0x0, 0x3ffb507, 0x7, 0x7d7b8e0, ...)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:2857 +0x587
github.com/mitchellh/go-glint/flex.nodeComputeFlexBasisForChild(0xc000c1aa00, 0xc000c1b100, 0x42960000, 0x1, 0x429600007fc00001, 0x7fc00001, 0x0, 0x1, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1070 +0x3fc
github.com/mitchellh/go-glint/flex.nodelayoutImpl(0xc000c1aa00, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0xc00137f100, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1645 +0xbea
github.com/mitchellh/go-glint/flex.layoutNodeInternal(0xc000c1aa00, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0x0, 0x3ffb507, 0x7, 0x7d7b8e0, ...)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:2857 +0x587
github.com/mitchellh/go-glint/flex.nodeComputeFlexBasisForChild(0xc000c1a300, 0xc000c1aa00, 0x42960000, 0x1, 0x429600007fc00001, 0x7fc00001, 0x0, 0x1, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1070 +0x3fc
github.com/mitchellh/go-glint/flex.nodelayoutImpl(0xc000c1a300, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0x0, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1645 +0xbea
github.com/mitchellh/go-glint/flex.layoutNodeInternal(0xc000c1a300, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0x0, 0x3ffb507, 0x7, 0x7d7b8e0, ...)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:2857 +0x587
github.com/mitchellh/go-glint/flex.nodeComputeFlexBasisForChild(0xc000c19c00, 0xc000c1a300, 0x42960000, 0x1, 0x429600007fc00001, 0x7fc00001, 0x0, 0x1, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1070 +0x3fc
github.com/mitchellh/go-glint/flex.nodelayoutImpl(0xc000c19c00, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0x100c400, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1645 +0xbea
github.com/mitchellh/go-glint/flex.layoutNodeInternal(0xc000c19c00, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc0000142960000, 0x0, 0x3ffb507, 0x7, 0x7d7b8e0, ...)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:2857 +0x587
github.com/mitchellh/go-glint/flex.nodeComputeFlexBasisForChild(0xc000cfca00, 0xc000c19c00, 0x4296000042960000, 0x1, 0x429600007fc00001, 0xc07fc00001, 0x0, 0x1, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1070 +0x3fc
github.com/mitchellh/go-glint/flex.nodelayoutImpl(0xc000cfca00, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc000017fc00001, 0x46f4101, 0x7d7b8e0)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:1645 +0xbea
github.com/mitchellh/go-glint/flex.layoutNodeInternal(0xc000cfca00, 0x7fc0000142960000, 0x1, 0x1, 0x0, 0x7fc000017fc00001, 0x1, 0x3ffb1db, 0x7, 0x7d7b8e0, ...)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:2857 +0x587
github.com/mitchellh/go-glint/flex.CalculateLayout(0xc000cfca00, 0x7fc000017fc00001, 0x1)
/go/pkg/mod/github.com/mitchellh/[email protected]/flex/yoga.go:3040 +0x120
github.com/mitchellh/go-glint.(*Document).RenderFrame(0xc0000a2410)
/go/pkg/mod/github.com/mitchellh/[email protected]/document.go:178 +0x1f1
github.com/mitchellh/go-glint.(*Document).Close(0xc0000a2410, 0xc0005abd01, 0x10575300)
/go/pkg/mod/github.com/mitchellh/[email protected]/document.go:95 +0x145
github.com/hashicorp/waypoint/sdk/terminal.(*glintUI).Close(0xc000388040, 0x47175c0, 0xc000388040)
/home/circleci/project/waypoint/sdk/terminal/glint.go:31 +0x2e
github.com/hashicorp/waypoint/internal/cli.(*baseCommand).Close(0xc000af8000, 0x0, 0x0)
/home/circleci/project/waypoint/internal/cli/base.go:96 +0x76
github.com/hashicorp/waypoint/internal/cli.Main(0xc000aa4ee0, 0x2, 0x2, 0x0)
/home/circleci/project/waypoint/internal/cli/main.go:102 +0x5e0
main.main()
/home/circleci/project/waypoint/cmd/waypoint/main.go:14 +0xa2
The output is also pretty funky. I'll get another gif of that.
from waypoint.
thrashr888
commented on July 17, 2024
FYI waypoint up -plain works just fine and does not crash either.
The crash no longer happens at all so maybe this issue can be closed. 👍
from waypoint.
mitchellh
commented on July 17, 2024
Great! Note that docker rewriting the first line periodically happened with the last implementation too. This is Docker clearing their terminal incorrectly, not on our end.
I’ll look at your crash in the other issue
from waypoint.
Related Issues (20)
- Feature: Load custom Config Sourcer plugins
- CLI: Config Sourcers do not display the workspace scope
- Waypoint Helm does not support private chart repository HOT 1
- Vulnerability of dependency "helm.sh/helm/v3"
- The "waypoint server install -platform=ecs" should create HTTP target group with protocol TLS:9702 instead of TCP:9702 to allow custom domain with SSL
- gRPC health check "ValidationError: Health check matcher HTTP code cannot be empty"
- K8s Ingress Releaser Support for IngressClass
- `waypoint runner install -platform=ecs` fails due to policy syntax errors
- [ECS] Mark sidecar container as essential
- [ECS] Setup alternative log drivers & allow FireLens configuration
- [ECS] Define container dependencies
- Tutorials are not complete: Tagging Docker image: nomad-nodejs-web:latest Error parsing reference HOT 2
- Build with aws-ecr-pull requiring docker.AccessInfo due to no registry stanza with remote runner HOT 2
- A bug in the go-argmapper library
- entrypoint: Failed sending inlinekeepalive
- AWS ECS releaser reports empty target group as healthy
- [Nomad] nomad-jobspec not work with node_pool
- waypoint.server.grpc: failed to register hostname: authentication handshake failed: x509 HOT 2
- run waypoint in consul service mesh
- Migrate away from deprecated `heroku/buildpacks:20` CNB builder image HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from waypoint.