Comments (5)
armon
commented on June 3, 2024
@superfell This is a pretty bad issue. Thanks for digging in. I think we should merge the test changes in once we have a fix, so that the tests are not always failing.
from raft.
superfell
commented on June 3, 2024
Sure, that's reasonable.
from raft.
armon
commented on June 3, 2024
@superfell So thinking about this, I feel like the right behavior is for all transactions after the RemovePeer to be subject to ErrLeadershipLost. Assuming totally serial behavior, after the RemovePeer(leader) finishes, nothing is expected to make progress on the leader. Does this make sense?
from raft.
superfell
commented on June 3, 2024
Makes sense to me. In terms of a fix, i'm currently running tests on adding a !precommit check around the r.peers = nil / r.peerStore.SetPeers([]string{r.localAddr}) pair in processLog (~line 1161). I think that means you may see one or two additional log entries go along with the removePeer, but they'll be managed correctly.
from raft.
armon
commented on June 3, 2024
@superfell Take a look at PR #81. I think that should fix the issue, so far I haven't been able to get a test failure.
from raft.
Related Issues (20)
- How to bootstrap a raft cluster with a fixed node setting? HOT 15
- Using node heartbeats in business logic HOT 1
- New node not receiving raft.Configuration after leader calls AddVoter HOT 3
- Cluster unable to elect a leader after restarting a follower and stopping the leader while the follower is down HOT 2
- How to costumize the Logger Name HOT 2
- Is there a way to make Snapshotting optional? HOT 2
- Your repo doesn't have documentation!
- Enhancement: persist commit index in LogStore to accelerate recovery HOT 4
- Test failed on latest branch: TestRaft_LeadershipTransferToBehindServer HOT 1
- Why the subsequent nodes not join the cluster HOT 2
- Why after calling RemoveServer for a node does it still continue to heartbeat it? HOT 2
- getting notified on losing follower heartbeat HOT 5
- Push to the notify channel and shutdown sign arriving,it is pick one of two but actually nobody know which one HOT 5
- Panic split-brain in appendEntries call HOT 2
- How to observe on follower connecting to cluster ? HOT 1
- How to bootstrap a raft cluster with a single node? HOT 2
- Use pebbledb as raft logstore & stablestore, restart raft cluster nodes all pebbledb data will be lost? HOT 13
- Ability for peers to denote others/themselves as too laggy to accept requests HOT 8
- Inconsistent Raft Latency on Different Infrastructures HOT 8
- Allow network transfer of snapshot to be cancelled during shutdown
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from raft.