Node doesn't vote for current leader about raft HOT 6 CLOSED

Perhaps the real problem is that replicateTo will continue to send AE requests after its stepped down as leader. [it looks like this doesn't stop until a new leader is elected]

from raft.

One possible fix would be to add the stopCh to the select list in replicateTo, this would break the feature where it tries to replicate upto a known index when a peer is removed, however various places read the stopCh and loose this replicate up to index number, so its not clear that it works consistently anyway.

If the replicate to an index on peer removal is needed, then it seems like there probably needs to be 2 stop channels, one for an unconditional stop, and one for stop at this index.

Trying to continue to replicate to Index point X (where X was decided while still leader) but no longer leader seems dangerous.

from raft.

@superfell I think this is a race condition, in that AE may be inflight already when the leader steps down. We do stop replication immediately on step down, but things may already have been inflight.

from raft.

I think allowing a vote for the current leader seems fine, since the node's state is still logically consistent.

from raft.

My thinking ended up all over the map on this one, but in the end that was the conclusion i came to as well. [but got distracted by the other issue]. Happy to put together a PR for that.

from raft.

@superfell Sounds good, I'll keep an eye out for the PR.

from raft.