Comments (10)
@NoamGaash @shootermv I close this issue because the related pr was merged
from open-bus-map-search.
@NoamGaash
Yes, intuitively you see time (values in general) increasing as it goes to the right, like mathematical plots (XY).
But also depends on requirements if they say otherwise.
from open-bus-map-search.
@VSciFlight - It looks like the issue is the inherited direction of the application.
According to the investigation - it is the "Recharts" library that is used to draw these charts (correct me if I was mistaken).
This one can be fixed by applying a reversed={true}
prop to the <XAxis>
component.
The fix can be applied here
After applying the mentioned prop - a charts graph looks like the following:
Also, there is another question here. Should we also change the location of the YAxis
? To be in the opposite orientation like this?
@NoamGaash
Please assign this one to me. What I mentioned should fix this issue. Or maybe there is another solution that you can think about and I'll be happy to execute.
from open-bus-map-search.
@NoamGaash
What about this one?
Can I start to work on it?
from open-bus-map-search.
@AlexKomanov
sure! thanks
from open-bus-map-search.
@AlexKomanov @shootermv
just one question - are we sure that the X axis shouldn't be RTL, since the application is in Hebrew?
from open-bus-map-search.
@VSciFlight you're right
https://www.facebook.com/groups/uximembers/posts/7669185879775101/?__cft__[0]=AZX0TZWwo9Jhc_b7j9W2oHLnCQMrMg84HiilA3M4WJI1y3wqJtXgkkh-1yw3VMToeiHiTk8WFt79RSQX4v7V3gRvfOPhyjhl1cTulAN3tKPYy5oxmr8lJPBD3YpxfTQxIRRc-xqZq_Jfjg72VwayHE3K5ATd7fEXhtX-ldz3EHWxFQ&__tn__=%2CO%2CP-R
thanks!
from open-bus-map-search.
@NoamGaash
I am not a part of the group from where you shared a link. Can you please share here a screenshot?
Also, what is our action item here? To reverse the XAxis to be like the following?
cc: @VSciFlight
from open-bus-map-search.
@AlexKomanov
Yeah, I needed to mention that
from open-bus-map-search.
from open-bus-map-search.
Related Issues (20)
- בעיה במצב כהה HOT 3
- בעיה בטופס דיווח באגים HOT 8
- history tab says "line not found" when I finish selecting all fields HOT 3
- Pattern tab - shows wrong data HOT 4
- User wants to view "patterns of missed trips" HOT 4
- The "donations" tab in sidebar needs to open a pop up. Same as the icon in header
- ci: deploy a preview of the test report after every PR update HOT 3
- test: add visual tests for dark mode
- Apply code review comments HOT 5
- fix: DateSelector selector validation message issues
- changing the date in the gaps page doesn't refresh all of the data
- Show אינדיקציית החרגה informaion
- דרך אגד HOT 1
- test | block google analytics when running tests
- History tab - nothing happens when I finish selecting all fields
- user complaints - scrolling the map and the report page HOT 1
- צדשחהחיב
- מפה לפי קו
- card elements is hardy visible at dark mode HOT 1
- לא נטען היסטורית נסיעות
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-bus-map-search.