Git Product home page Git Product logo

Comments (15)

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024 1

yes, you are right! the best api should contain an event detail, thank you for your contribution!

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024 1

Thanks for this great package!

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024 1

ok, i will public a new release after some hours.

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024

As I understand, you means that <textarea> should be added a prop name.What I want to make sure is that prop name custom (for example, name={this.props.foo})? or just add a props name='markdown-content' ?

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024

OK, I already understand what your mean. Thanks your pull request, and I have merged it.

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024

Thanks @HarryChen0506! I just add a new pull request. The validation library I use need to access the validity state of the input, therefore is necessary to forward the event into the onEmit method. Thanks again for your help

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024

Would you mind to create a release with this latest change so I can install the package from npm? Sorry to bother.

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024

Hello, my friend, I have published a new version(v0.4.4) in NPM. you can use it as follows. :-)

handleEditorChange = ({ html, text}, event) => {
    console.log('handleEditorChange', event)
  }

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024

Great!!! Thanks man!

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024

@HarryChen0506 I think is necessary to change the onChage? function in the index.d.ts file to accept the event param as follows:


    onChange?: (data: {
      text: string;
      html: string;
    }, event: any) => void;

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024

yes, I forgot it. I will correct it next time. Have a nice experience :-)

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024

Thaaaanks! Sorry for bother a lot. If you can wrap that in a release, you will make my day. I'm currently patching my local version but this is not sustainable

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024

I am happy to do it, so you don't have to feel sorry. I will fix it after work as soon as possible.

from react-markdown-editor-lite.

dcalvom avatar dcalvom commented on July 18, 2024

Awesome! You rock!

from react-markdown-editor-lite.

HarryChen0506 avatar HarryChen0506 commented on July 18, 2024

Hello, the latest version(v0.4.5) has been released. If you have any request, just tell us. :-)

from react-markdown-editor-lite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.