Pull Request? about cron-parser HOT 4 CLOSED

Sounds, good. I should be done by the end of next weekend then do the pull request. If I have time I'm going to review all the open bug tickets and see if I can close some out with this pr.

Edit: Not sure if you are aware but you can install the updated version for testing via: yarn add https://github.com/MichaelLeeHobbs/cron-parser it's fully functional as of now and I should not break it at this point.

from cron-parser.

@harrisiirak I've added a bunch of tests for #156 see the end of https://github.com/MichaelLeeHobbs/cron-parser/blob/master/tests/CronExpression.test.ts I don't know if you had at some point fixed these or I accidentally fixed them in the refactor. They all seem to work correctly for me. The only issue I found was CronExpression.stringify does not return the original value and that would be very difficult to impossible. So I sort of cheated and added CronExpression.toString which return this.#expression || this.stringify(true); As long as this was a parsed expression then this.#expression will be the original expression.

I've also added a fix for #153 and #299.

Obviously, I still need to document and comment the code which I will do after I am done looking at issues.

Edit: Fixed #190, the refactor supports CJS and ESM.
Edit: Added a fix for #244 in the form of strict mode which defaults to false. See test should throw an error for expression missing fields when in strict mode (#244)

from cron-parser.

Hi @MichaelLeeHobbs!

Looks promising. I started with TS rewrite some time ago but haven't gotten that far. I'm more than happy to receive this as a PR. Although, reviewing this will be tedious work (but it's definitely doable) - actual TS conversion itself + some overall structural improvements.

Best regards

from cron-parser.

If I have time I'm going to review all the open bug tickets and see if I can close some out with this pr.

Solving some low-hanging bugs/issues would be a nice bonus if they don't create too much extra work. I do like what is going in your fork. However, I still prefer reviewing something rather concentrated and compact - if possible, I even consider somehow splitting this up into smaller pieces, so it makes sense while reviewing.

from cron-parser.