Git Product home page Git Product logo

Comments (3)

rambhosale avatar rambhosale commented on June 26, 2024 2

@bradrydzewski
I created a PR for accepting around ~5MB(5000000 chars), please have a look at it

from gitness.

bradrydzewski avatar bradrydzewski commented on June 26, 2024

the type should be a blob for sqlite and a bytea for postgres to allow for much larger file stores [1] to align with drone. If there is a limit of 1024 bytes in place, I agree that it definitely needs to be improved. Would you consider sending a pull request and then I can ask the team to review?

Note that I don't think this is something we should need to make configurable. We should either remove the limit entirely or place a limit sufficiently large enough that it will handle all modern use cases (e.g. 5mb)

[1] https://github.com/harness/gitness/blob/drone/store/shared/migrate/postgres/files/009_create_table_secrets.sql#L7

from gitness.

rambhosale avatar rambhosale commented on June 26, 2024

Closing as #3494 is merged

from gitness.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.